Fixes a few things with templates and creates an OSX fat executable for X86_64/ARM64 native executable - #33
Open
Super-Genius wants to merge 6 commits into
Open
Super-Genius wants to merge 6 commits into
Super-Genius wants to merge 6 commits into
Conversation
requarks/changelog-action errors out (and fails the whole job) when commits since the previous tag don't follow conventional-commit format, which skips the downstream Release step entirely. The OSX and Linux builds already succeed but never publish because of this. Mark the step continue-on-error and ignore invalid commits so the Release step always runs on tag pushes.
windows-latest now ships Visual Studio 18 (2026), so the hardcoded 'Visual Studio 17 2022' generator fails configure with 'could not find any instance of Visual Studio'. Move Windows to the Ninja generator (already used by Linux/Mac) and set up the MSVC environment via ilammy/msvc-dev-cmd, which is immune to VS-version churn on the runner image. Pass VCPKG_TARGET_TRIPLET explicitly and unify the install target to lowercase 'install' (Ninja is single-config, so 'INSTALL' only existed for the multi-config VS generator).
ilammy/msvc-dev-cmd initializes the VS Developer environment, which
re-points VCPKG_ROOT at the VS-bundled vcpkg
('C:\Program Files\...\VC\vcpkg'). That path contains spaces, so the
template-expanded toolchain reference got word-split by bash, the vcpkg
toolchain failed to load, and cmake could not find Ninja or the MSVC
compilers. Restore our bootstrapped C:/vcpkg for Windows inside the
Configure step (after msvc-dev-cmd has run) and reference the bash
variable, quoted, instead of the pre-expanded template.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.