Add rule to convert t.Error,t.Fatal to testify - #318
Open
thespags wants to merge 1 commit into
Open
Conversation
Author
|
Hi @Antonboom, a large set of changes, but hopefully straightforward common cases of converting from old t.Error/t.Fatal patterns in using testimony. |
Author
|
Hi, @Antonboom, thanks for taking a look. I did walk over manual_assert.go from what the LLM spat out to ensure we were using shared helpers, and improve code flow. Let me know what I can do to move the review along. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I keep running into teammates using t.Error/t.Fatal, especially now with LLMs. I've set up skills and spoken about sticking with
testify, yet some snippets sneak by.Here's a new check to provide a warning and autofixer for common
if {expr } { t.Error(...) }patterns