Implement elements-match checker - #303
Open
mmorel-35 wants to merge 6 commits into
Open
Conversation
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
mmorel-35
force-pushed
the
elements-match
branch
from
March 16, 2026 06:59
509f881 to
bded4b4
Compare
Contributor
|
I had no idea ElementsMatch existed 😱😅🤣 |
ccoVeille
reviewed
Mar 18, 2026
mmorel-35
pushed a commit
to mmorel-35/testifylint
that referenced
this pull request
May 28, 2026
Removed elements-match section from CONTRIBUTING.md to simplify the document.
…sort.Slice` Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
elements-matchchecker from the CONTRIBUTING.md open-for-contribution list, which detects verbose slice comparison patterns that should useassert.ElementsMatch.What it detects
Changes
internal/checkers/elements_match.go—AdvancedCheckerthat walksast.BlockStmtnodes looking for the 3-statement tripletslices.Sort(x)+slices.Sort(y)+assert.True(t, slices.Equal(x, y)). Handles commuted sort order and bothslices(Go 1.21) andgolang.org/x/exp/slices. Includes a full autofix that removes the two sort statements and rewrites the assertion.internal/testgen/gen_elements_match.go— Test generator with errored and golden templates.README.md— Added to the checkers table and reference section.CONTRIBUTING.md— Removed from the open-for-contribution list.