Repository navigation
Report update command copy failures - #329
Open
dajiaohuang wants to merge 2 commits into
Open
dajiaohuang wants to merge 2 commits into
dajiaohuang wants to merge 2 commits into
Conversation
dajiaohuang
marked this pull request as ready for review
November 14, 2026 10:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When clipboard access is unavailable or denied, the update command's Copy button currently gives no feedback. Show an accessible error and leave the command available for manual copying in both web and desktop update panels. A later successful copy clears the error and confirms success.
Validation: mounted the actual update panel in headless Chrome with synthetic version data and a fake desktop bridge. Both web and desktop reproduced silent failure before the change and showed the failure, successful retry and timed success reset afterward. The web case also tested changing the command during a pending copy. Focused ESLint and
git diff --checkpassed; independent exact-head source review found no scoped blocker. Real clipboard permissions, packaged desktop updates and CI were not tested.PR #309 also changes the desktop update panel. A three-way check found a conflict between #309 head
fed50ac2ce83903e3cd8ac998a2fe016b69fa7b5and this PR's headc5baec269904a3822865b74b40be3fb8a2fb2880, both based on8ededd4b0f6b0021ac507d0ca05ae83bce48a2df. When either head changes or integrates, reconcile the current source and verify updater ordering together with copy feedback. Combined runtime is untested.