Skip to content

Report update command copy failures - #329

Open
dajiaohuang wants to merge 2 commits into
Anil-matcha:mainfrom
dajiaohuang:fix/update-command-copy-feedback
Open

dajiaohuang wants to merge 2 commits into
Anil-matcha:mainfrom
dajiaohuang:fix/update-command-copy-feedback

Conversation

@dajiaohuang

@dajiaohuang dajiaohuang commented Nov 14, 2026 •

Copy link
Copy Markdown

When clipboard access is unavailable or denied, the update command's Copy button currently gives no feedback. Show an accessible error and leave the command available for manual copying in both web and desktop update panels. A later successful copy clears the error and confirms success.

Validation: mounted the actual update panel in headless Chrome with synthetic version data and a fake desktop bridge. Both web and desktop reproduced silent failure before the change and showed the failure, successful retry and timed success reset afterward. The web case also tested changing the command during a pending copy. Focused ESLint and git diff --check passed; independent exact-head source review found no scoped blocker. Real clipboard permissions, packaged desktop updates and CI were not tested.

PR #309 also changes the desktop update panel. A three-way check found a conflict between #309 head fed50ac2ce83903e3cd8ac998a2fe016b69fa7b5 and this PR's head c5baec269904a3822865b74b40be3fb8a2fb2880, both based on 8ededd4b0f6b0021ac507d0ca05ae83bce48a2df. When either head changes or integrates, reconcile the current source and verify updater ordering together with copy feedback. Combined runtime is untested.

@dajiaohuang
dajiaohuang marked this pull request as ready for review November 14, 2026 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant