Repository navigation
Keep conversation visible when reaction storage is denied - #328
Open
dajiaohuang wants to merge 2 commits into
Open
dajiaohuang wants to merge 2 commits into
dajiaohuang wants to merge 2 commits into
Conversation
dajiaohuang
marked this pull request as ready for review
November 14, 2026 10:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When access to the browser's
localStorageproperty throws, loading reactions crashes the conversation during render. Catch storage access errors and retain unsaved reactions per thread in memory so successive reactions remain visible in the current page. Once storage accepts a write, persist the current map.Validation: seven reactions Node tests pass, covering denied getters, successive changes, thread separation, failed writes and recovery. Focused ESLint and
git diff --checkpass. At the preceding commit, a mounted Conversation in synthetic headless Chrome failed to render with a throwing getter before the fix and rendered after it; normal storage also rendered. An independent source/function review of the current head found no remaining same-tab blocker.Unsaved changes are lost on reload, and concurrent changes from another tab are not merged while the fallback is active. Real browser storage policies, mounted sequential interaction at this head, desktop packaging and CI were not tested.