Skip to content

Keep conversation visible when reaction storage is denied - #328

Open
dajiaohuang wants to merge 2 commits into
Anil-matcha:mainfrom
dajiaohuang:fix/reactions-storage-denied
Open

dajiaohuang wants to merge 2 commits into
Anil-matcha:mainfrom
dajiaohuang:fix/reactions-storage-denied

Conversation

@dajiaohuang

@dajiaohuang dajiaohuang commented Nov 14, 2026 •

Copy link
Copy Markdown

When access to the browser's localStorage property throws, loading reactions crashes the conversation during render. Catch storage access errors and retain unsaved reactions per thread in memory so successive reactions remain visible in the current page. Once storage accepts a write, persist the current map.

Validation: seven reactions Node tests pass, covering denied getters, successive changes, thread separation, failed writes and recovery. Focused ESLint and git diff --check pass. At the preceding commit, a mounted Conversation in synthetic headless Chrome failed to render with a throwing getter before the fix and rendered after it; normal storage also rendered. An independent source/function review of the current head found no remaining same-tab blocker.

Unsaved changes are lost on reload, and concurrent changes from another tab are not merged while the fallback is active. Real browser storage policies, mounted sequential interaction at this head, desktop packaging and CI were not tested.

@dajiaohuang
dajiaohuang marked this pull request as ready for review November 14, 2026 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant