Repository navigation
Preserve unread state beyond the recent list - #327
Open
dajiaohuang wants to merge 4 commits into
Open
dajiaohuang wants to merge 4 commits into
dajiaohuang wants to merge 4 commits into
Conversation
dajiaohuang
marked this pull request as ready for review
November 14, 2026 10:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sidebar requests only the 100 most recently active conversations. When a previously seen conversation falls outside that list, unread tracking currently drops its last-seen timestamp; if it later becomes active and returns, it is treated as read. Keep timestamps for absent conversations when the response fills the request limit, and prune absent entries when the response is shorter and therefore complete. Explicitly request the same limit used by unread tracking. When a bookmarked conversation outside that list is loaded, record its current activity as read too, without advancing it from an independently fetched list row before detail loads.
Validation: synthetic 100-conversation regressions verify that an evicted conversation becomes unread after later activity, that viewing an off-list conversation marks its current activity read, and that stale list rows and delayed detail do not advance or regress read state incorrectly. The unread and thread API Node suites passed 27 tests; focused ESLint had zero errors and four existing warnings. TypeScript passed with an isolated configuration excluding stale generated Next types; the default command failed on a stale generated reference to a removed temporary audit page. Browser, live backend and CI were not run.