Repository navigation
Keep engine installation status current - #326
Open
dajiaohuang wants to merge 3 commits into
Open
dajiaohuang wants to merge 3 commits into
dajiaohuang wants to merge 3 commits into
Conversation
dajiaohuang
marked this pull request as ready for review
November 14, 2026 08:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An older engine-install status request can finish after the user starts an install and replace the running operation with an idle status. The UI then hides Cancel and enables Install again while the operation is running. Ignore superseded status responses and invalidate pending status reads when starting or cancelling an operation. Keep failed cancellation feedback visible when later status polls succeed.
Validation: headless Chrome mounted the actual component with synthetic API responses. A delayed idle status reproduced the missing Cancel button before the change; after the change the running operation and disabled Install button remained. A status response slower than the polling interval also completed successfully despite later polls. A failed cancellation remained visible through successful polls. Focused ESLint and
git diff --checkpassed. Real desktop installation, backend integration and CI were not run.