Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions frontend/components/workflows/WorkflowCanvas.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,8 @@ export interface WorkflowCanvasProps {
onSelectWorkflow: (id: number) => void;
onCreateWorkflow: () => void;
onUpdateWorkflow: (updated: Partial<Workflow>) => Promise<void>;
onRunWorkflow: () => Promise<void>;
workflowUnsaved: boolean;
canRunWorkflow: () => boolean;
onClose: () => void;
onRefreshRuns: () => Promise<void>;
}
Expand Down Expand Up @@ -663,7 +664,8 @@ export function WorkflowCanvas({
onSelectWorkflow,
onCreateWorkflow,
onUpdateWorkflow,
onRunWorkflow,
workflowUnsaved,
canRunWorkflow,
onClose,
onRefreshRuns,
}: WorkflowCanvasProps) {
Expand Down Expand Up @@ -2172,9 +2174,9 @@ export function WorkflowCanvas({

// Execute workflow live across canvas
const handleTriggerFullRun = async () => {
if (!canRunWorkflow()) return;
try {
setIsExecutingWorkflow(true);
await onRunWorkflow();
const run = await api.startWorkflowRun(
workflow.id,
{ message: "Triggered from visual canvas" },
Expand All @@ -2191,6 +2193,7 @@ export function WorkflowCanvas({

// Run isolated step
const handleRunStep = async (stepId: string) => {
if (!canRunWorkflow()) return;
try {
setRunningStepId(stepId);
const res = await api.runWorkflowStep(workflow.id, stepId, {
Expand Down Expand Up @@ -2361,7 +2364,8 @@ export function WorkflowCanvas({

<button
type="button"
disabled={isExecutingWorkflow}
disabled={isExecutingWorkflow || workflowUnsaved}
title={workflowUnsaved ? "Save workflow changes before running" : undefined}
onClick={handleTriggerFullRun}
className="flex items-center gap-2 px-4 py-1.5 rounded-lg text-xs font-semibold bg-white text-zinc-950 hover:bg-zinc-100 shadow-md transition-all active:scale-95 disabled:opacity-50"
>
Expand Down Expand Up @@ -4331,7 +4335,7 @@ export function WorkflowCanvas({
{/* Primary Trigger Button: Run now / Run workflow / Send test webhook */}
<button
type="button"
disabled={isLocked || isExecutingWorkflow}
disabled={isLocked || isExecutingWorkflow || workflowUnsaved}
onClick={() => handleTriggerFullRun()}
className="w-full py-1.5 px-3 rounded-xl bg-white text-zinc-950 font-semibold text-xs flex items-center justify-center gap-1.5 hover:bg-zinc-200 transition-colors shadow-sm disabled:opacity-50 active:scale-98"
>
Expand Down Expand Up @@ -4531,7 +4535,7 @@ export function WorkflowCanvas({
{/* Inline Full-width "Run" Button */}
<button
type="button"
disabled={isRunningThis}
disabled={isRunningThis || workflowUnsaved}
onClick={() => handleRunStep(step.id)}
className="w-full py-2 rounded-xl bg-zinc-800/90 hover:bg-zinc-700 text-zinc-200 text-xs font-semibold flex items-center justify-center gap-1.5 transition-all shadow-sm active:scale-98 disabled:opacity-50 shrink-0"
>
Expand Down
111 changes: 86 additions & 25 deletions frontend/components/workflows/WorkflowsPanel.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
"use client";

import { useCallback, useEffect, useState } from "react";
import { useCallback, useEffect, useRef, useState } from "react";
import {
api,
type Agent,
Expand All @@ -17,6 +17,19 @@ interface WorkflowsPanelProps {
onClose: () => void;
}

interface WorkflowSave {
draft: Workflow;
pending: Partial<Workflow> | null;
saving: boolean;
error: string | null;
}

const queuedChanges = (save: WorkflowSave) => save.pending;
const applyWorkflowEdit = (save: WorkflowSave, partial: Partial<Workflow>) => {
save.draft = { ...save.draft, ...partial };
save.pending = { ...save.pending, ...partial };
};

const DEFAULT_WORKFLOW_STEPS: WorkflowStep[] = [
{
id: "trigger_1",
Expand Down Expand Up @@ -102,6 +115,18 @@ export function WorkflowsPanel({ agents, engines = [], onClose }: WorkflowsPanel
const [runs, setRuns] = useState<WorkflowRun[]>([]);
const [loading, setLoading] = useState(true);
const [error, setError] = useState<string | null>(null);
const [saveErrors, setSaveErrors] = useState<Record<number, string>>({});
const [unsavedWorkflows, setUnsavedWorkflows] = useState<Record<number, boolean>>({});
const saves = useRef<Record<number, WorkflowSave>>({});

useEffect(() => {
const warnBeforeLeave = (event: BeforeUnloadEvent) => {
if (Object.keys(saves.current).length === 0) return;
event.preventDefault();
};
window.addEventListener("beforeunload", warnBeforeLeave);
return () => window.removeEventListener("beforeunload", warnBeforeLeave);
}, []);

const loadData = useCallback(async () => {
try {
Expand All @@ -121,7 +146,7 @@ export function WorkflowsPanel({ agents, engines = [], onClose }: WorkflowsPanel
setWorkflows([initial]);
setSelectedWorkflowId(initial.id);
} else {
setWorkflows(wfs);
setWorkflows(wfs.map((workflow) => saves.current[workflow.id]?.draft ?? workflow));
setSelectedWorkflowId((prev) => (prev !== null ? prev : wfs[0].id));
}
setRuns(rList);
Expand Down Expand Up @@ -189,31 +214,56 @@ export function WorkflowsPanel({ agents, engines = [], onClose }: WorkflowsPanel
}
};

const handleUpdateWorkflow = async (partial: Partial<Workflow>) => {
if (!activeWorkflow) return;
try {
const updated = await api.updateWorkflow(activeWorkflow.id, partial);
setWorkflows((prev) =>
prev ? prev.map((w) => (w.id === updated.id ? updated : w)) : [updated]
);
} catch (err) {
console.error("Failed to update workflow:", err);
const flushWorkflow = async (id: number) => {
const save = saves.current[id];
if (!save || save.saving || save.error || !save.pending) return;
save.saving = true;
while (save.pending) {
const pending = save.pending;
save.pending = null;
try {
const updated = await api.updateWorkflow(id, pending);
save.draft = { ...updated, ...queuedChanges(save) };
const draft = save.draft;
setWorkflows((prev) => prev?.map((workflow) => workflow.id === id ? draft : workflow) ?? prev);
} catch (err) {
save.pending = { ...pending, ...queuedChanges(save) };
save.error = err instanceof Error ? err.message : String(err);
setSaveErrors((old) => ({ ...old, [id]: save.error! }));
break;
}
}
save.saving = false;
if (!save.pending && !save.error) {
delete saves.current[id];
setUnsavedWorkflows((old) => { const next = { ...old }; delete next[id]; return next; });
}
};

const handleRunWorkflow = async () => {
const handleUpdateWorkflow = async (partial: Partial<Workflow>) => {
if (!activeWorkflow) return;
try {
await api.startWorkflowRun(activeWorkflow.id, {
message: "Interactive manual run from visual canvas",
});
const freshRuns = await api.listAllWorkflowRuns(50);
setRuns(freshRuns);
} catch (err) {
alert(`Run failed: ${err instanceof Error ? err.message : String(err)}`);
}
const id = activeWorkflow.id;
const save = saves.current[id] ?? { draft: activeWorkflow, pending: null, saving: false, error: null };
applyWorkflowEdit(save, partial);
saves.current[id] = save;
setUnsavedWorkflows((old) => ({ ...old, [id]: true }));
const draft = save.draft;
setWorkflows((prev) => prev?.map((workflow) => workflow.id === id ? draft : workflow) ?? prev);
await flushWorkflow(id);
};

const retryWorkflow = (id: number) => {
const save = saves.current[id];
if (!save) return;
save.error = null;
setSaveErrors((old) => { const next = { ...old }; delete next[id]; return next; });
void flushWorkflow(id);
};

const refreshRuns = useCallback(async () => {
setRuns(await api.listAllWorkflowRuns(50));
}, []);

if (loading && !workflows) {
return (
<div className="fixed inset-0 z-50 flex items-center justify-center bg-[#0b0c0e] text-white">
Expand Down Expand Up @@ -246,7 +296,13 @@ export function WorkflowsPanel({ agents, engines = [], onClose }: WorkflowsPanel
if (!activeWorkflow) return null;

return (
<>
{Object.entries(saveErrors).map(([id, message]) => <div key={id} role="alert" className="fixed top-14 left-1/2 z-[100] -translate-x-1/2 rounded-lg border border-rose-700 bg-zinc-900 px-4 py-3 text-sm text-white shadow-lg">
<span>Workflow changes were not saved: {message}. Your edits are still here. </span>
<button type="button" className="underline" onClick={() => retryWorkflow(Number(id))}>Retry saving</button>
</div>)}
<WorkflowCanvas
key={activeWorkflow.id}
workflow={activeWorkflow}
workflows={workflows || []}
agents={agents}
Expand All @@ -255,9 +311,14 @@ export function WorkflowsPanel({ agents, engines = [], onClose }: WorkflowsPanel
onSelectWorkflow={(id) => setSelectedWorkflowId(id)}
onCreateWorkflow={handleCreateWorkflow}
onUpdateWorkflow={handleUpdateWorkflow}
onRunWorkflow={handleRunWorkflow}
onClose={onClose}
onRefreshRuns={loadData}
workflowUnsaved={Boolean(unsavedWorkflows[activeWorkflow.id])}
canRunWorkflow={() => !saves.current[activeWorkflow.id]}
onClose={() => {
if (Object.keys(saves.current).length && !window.confirm("Some workflow changes have not been saved. Close anyway?")) return;
onClose();
}}
onRefreshRuns={refreshRuns}
/>
</>
);
}
}