Repository navigation
Report chat link copy failures - #320
Draft
dajiaohuang wants to merge 1 commit into
Draft
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When both clipboard methods fail, copying a chat link gives no feedback. Report the failure and clear any previous copied indicator so the person can retry.
Validation: headless Chrome on the actual chat page with a synthetic API and controlled clipboard reproduced the silent failure; after the change, failure is reported and a successful copy still shows confirmation. Focused ESLint had zero errors and six existing warnings;
git diff --checkpassed. Merge-tree checks with Drafts #260 and #318 were clean; combined runtime, desktop clipboard, hosted and CI checks were not run. The new message has English and Spanish strings; other locales use the existing English fallback.