Repository navigation
Keep catalog page errors with their search - #319
Draft
dajiaohuang wants to merge 1 commit into
Draft
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a person changes the app search while an older page request is pending, a failure from that old request appears above the new results. Associate paging errors with the query and first page that produced them, separately from account errors, so a current paging failure remains visible.
Validation: headless Chrome on the actual Apps page with controlled API responses reproduced the stale error before the change. Afterward, the old error stayed hidden on new results, a current paging failure appeared, and changing search cleared it. Focused ESLint and
git diff --checkpassed. Real Composio, hosted, browser-to-backend integration and CI were not run.