Skip to content

Keep catalog page errors with their search - #319

Draft
dajiaohuang wants to merge 1 commit into
Anil-matcha:mainfrom
dajiaohuang:fix/apps-catalog-stale-page
Draft

dajiaohuang wants to merge 1 commit into
Anil-matcha:mainfrom
dajiaohuang:fix/apps-catalog-stale-page

Conversation

@dajiaohuang

Copy link
Copy Markdown

When a person changes the app search while an older page request is pending, a failure from that old request appears above the new results. Associate paging errors with the query and first page that produced them, separately from account errors, so a current paging failure remains visible.

Validation: headless Chrome on the actual Apps page with controlled API responses reproduced the stale error before the change. Afterward, the old error stayed hidden on new results, a current paging failure appeared, and changing search cleared it. Focused ESLint and git diff --check passed. Real Composio, hosted, browser-to-backend integration and CI were not run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant