changed the color of the title, gender, bio in the card#113
Closed
ShouravRakshit wants to merge 4 commits intoAnidion:mainfrom
Closed
changed the color of the title, gender, bio in the card#113ShouravRakshit wants to merge 4 commits intoAnidion:mainfrom
ShouravRakshit wants to merge 4 commits intoAnidion:mainfrom
Conversation
kevin-van
approved these changes
Feb 10, 2025
kevin-van
left a comment
kevin-van
left a comment
There was a problem hiding this comment.
Please resolve comments before merging :)
| } | ||
| } | ||
|
|
||
| private func renderTextWithEmoji(_ emoji: String, _ text: String) -> HStack<TupleView<(Text, Text)>> { |
There was a problem hiding this comment.
This stuff just got moved to the bottom? No code changes?
Contributor
Author
There was a problem hiding this comment.
yes pretty much
| .shadow(color: isTopCard ? getShadowColor() : (isSecondCard && dragOffset.width != 0 ? Color.gray.opacity(0.2) : Color.clear), radius: 10, x: 0, y: 3) | ||
| .shadow( | ||
| color: isTopCard | ||
| ? getShadowColor() |
There was a problem hiding this comment.
Its typically not good practice to do nested ternary expressions.
Maybe comment what its doing since its verbose?
Contributor
Author
There was a problem hiding this comment.
I feel like this happened when I pasted this code as the original one was not working so yeah.
Contributor
Author
|
creating the pr in the new one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.