ci: bump actions/checkout and actions/setup-node off the retired Node 12/16 runtimes - #177
Open
boleklebovski wants to merge 1 commit into
Open
Conversation
Six checkout pins were on v3 and one on v2, plus setup-node@v3. Those majors run on the retired Node 16 and Node 12 action runtimes. Cache actions and third-party actions are intentionally left untouched. Signed-off-by: boleklebovski <160799963+boleklebovski@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
As CONTRIBUTING asks, here is the explanation up front.
The workflows pin
actions/checkoutatv3in six places and atv2in one, plusactions/setup-node@v3. Both majors run on action runtimes GitHub has retired (Node 16 forv3, Node 12 forv2), so every CI run reports deprecation warnings. This bumps those pins tov4:.github/workflows/ci.ymlactions/checkout@v3actions/checkout@v4.github/workflows/ci-deep.ymlactions/checkout@v3actions/checkout@v4.github/workflows/ci-deep.ymlactions/setup-node@v3actions/setup-node@v4.github/workflows/ci-deep.ymlactions/checkout@v2actions/checkout@v4.github/workflows/coverage.ymlactions/checkout@v3actions/checkout@v4The
v2pin atci-deep.yml:72(thefoundry-testsjob) is the odd one out — every other checkout in the repository was already a major ahead of it.checkoutandsetup-nodeare stateless, so the bump carries no behavioural change here: no inputs are added, removed or renamed.Deliberately left alone
actions/cache@v3in.github/actions/setup-repo/action.yml, and theactions/cache/save@v3/actions/cache/restore@v3steps. Moving cache tov4changes the cache backend and invalidates existing entries once. The cache steps currently succeed, so that is a judgement call for you rather than something to slip into a version-bump PR. Happy to add it if you would like it in the same change.oven-sh/setup-bun@v1andfoundry-rs/foundry-toolchain@v1—v1is the current major for both, not a stale pin.One thing worth flagging separately
The scheduled
ci-deep.ymlruns have been failing at theRun Foundry testsstep every week since at least 2026-07-12. That is unrelated to action versions and this PR does not touch it — mentioning it only so the existing red run is not read as a regression from this change.Verification
All three files parse as YAML with job names unchanged, and each target major exists upstream.