fix: stop double-counting partial offload in ranking#108
Merged
Conversation
143ea1b to
b3f3e98
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #105.
Follow-up from #104.
What changed
This fixes a ranking bug where strong models that need partial offload could be buried below weaker full-GPU models.
The old score path counted VRAM fit more than once:
quality_scorealready applied the partial-offload quality multiplierquality_scorealso included the speed adjustment+15bonus forfull_gpuThat made the displayed score and the actual rank disagree. On an RTX 3060 12GB-style setup,
Qwen/Qwen3.6-27Bcould show a higher score than several models above it, but still land near the bottom because the sort key applied the extra full-GPU bonus.This PR keeps final sorting closer to the displayed score. Full-GPU candidates are still favored through the runtime-fit and speed terms, but the sort key no longer adds a second full-GPU bonus.
I also made the partial-offload multiplier more granular:
Local QA
Manual checks:
Qwen/Qwen3.6-27Bmoves from buried near the bottom to the top group with a partial-offload warning.Qwen/Qwen3.6-27Bstays lower when the offload ratio and speed are not good enough.