Fix Medical Seer billing when chart context is missing - #66
Draft
cursor[bot] wants to merge 1 commit into
Draft
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
PAYG users were charged a tool_seer credit when Ask the Seer on Medical Astrology ran without a chart (starter questions fire with analysis=null). Reject missing chart context in the Seer gate before rate-limit and consumeBillingAction. Co-authored-by: Andy Oliver Rozario <andyrozario7@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
tool_seercredit when the user has no medical chart yet.enforceToolSeerGatecan now reject missing chart/reading context before rate-limit andconsumeBillingAction.Why this change is safe
MedicalSeerChatis always rendered on/tools/medical-astrology(Ask the Seer tab). Starter questions fire withanalysis: null. The gate billed, then the route 400'd with "Generate your medical astrology analysis first."Verification
pnpm test— 70 suites / 386 testspnpm run lint:securitypassedPre-existing
pnpm run securityhighbrowserslistadvisories are unchanged.Regression prevention
tests/unit/medicalSeerMissingChart.test.ts: missing analysis → 400 andconsumeBillingActionnot called; valid chart still bills.tests/unit/enforceToolSeerGate.test.ts:missingContextErrorreturns 400 before debit.Release checklist (solo-friendly)
Not in this PR: LLM/stream failure after a valid question with chart still debits with no refund helper.