Fix unauthenticated Vedic interpretation AI cost abuse and cache IDOR - #42
Draft
cursor[bot] wants to merge 1 commit into
Draft
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Unauthenticated POST /api/vedic-interpretations/* could burn Groq credits
and read/write users/{userId}/vedicInterpretations via Admin SDK using any
body userId. Gate all eight routes with owned Firebase Bearer auth and AI
rate limiting; lock in with an integration test.
Co-authored-by: ANDY OLIVER ROZARIO <AndyOliverR@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
userIdon all eight/api/vedic-interpretations/*routes before Groq generation or Admin cache R/W.Why this change is safe
userIddroveVedicInterpretationEnhancercache and (divisional)getUserProfile.Verification
pnpm run lint:securitypnpm test(62 suites / 333 tests)Regression prevention
tests/integration/vedic-interpretations-auth.test.ts(fails without auth gate).Release checklist (solo-friendly)
CI / Lint + JestCI / Playwright smokemain.Bug / impact
Unauthenticated callers could burn Groq via
callTextAIand read/writeusers/{userId}/vedicInterpretations(plus profile personalization IDOR on divisional).Root cause
Public App Router handlers accepted any
userIdwith no Bearer check.Fix
authorizeVedicInterpretationRequest+withRateLimit(rateLimiters.ai)on all eight routes.