fix: store real kafka partition+offset in Iceberg via KafkaRecordDeserializer#9
Closed
AndrewAct wants to merge 1 commit into
Closed
fix: store real kafka partition+offset in Iceberg via KafkaRecordDeserializer#9AndrewAct wants to merge 1 commit into
AndrewAct wants to merge 1 commit into
Conversation
…rializer Replace SimpleStringSchema with a custom KafkaRecordDeserializationSchema in both normalize.py and cdc_symbol_config.py so that kafka_partition and kafka_offset written to Iceberg silver/bronze layers reflect the actual Kafka record position instead of the placeholder -1. The -1 fallback path in iceberg_reader.py is retained for backward compatibility with rows written before this fix. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Replace
SimpleStringSchemawith a customKafkaRecordDeserializationSchemain bothnormalize.pyandcdc_symbol_config.pyso thatkafka_partitionandkafka_offsetwritten to Iceberg silver/bronze layers reflect the actual Kafka record position instead of the placeholder -1.The -1 fallback path in
iceberg_reader.pyis retained for backward compatibility with rows written before this fix.