Repository navigation
chore(repo-harness): refresh repo-local harness config to 0.32.0 - #590
Conversation
- rewrite .ai/harness/policy.json to the 0.32 key set (drops ~200 keys with no reader in 0.32; archcontext source does not read them) - .gitignore: adopt the slim managed block; runtime-state ignores now live in the user-level git excludes file - remove retired assets: .ai/hooks/README.md, .claude/templates/*.template.md, docs/prds/prd.template.md - skip repo-harness' generic docs/architecture/index.md stub: archimap.html stays the single architecture entry per AGENTS.md Verification: repo-harness init (apply + check-context-files SAFE); repo-harness state resolve -> idle, no blockers. Risk: low; config-only, no source or model change. Rollback: git revert this commit.
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
repo-harness acceptance claim |
Ancienttwo
left a comment
There was a problem hiding this comment.
repo-harness acceptance review
Round: 1
Subject: e3e0f37
Tier: medium
Verdict: FAIL
Reviewer: codex (gpt-6.1-terra)
Model relation: different-family
Cross-family review (Codex CLI, read-only). publication.acceptance_merge stays on. The .gitignore change removes repository-level ignores for local runtime state and settings, so ignoring them depends on each contributor's global excludes; the claim that no repository code reads the removed policy keys is inaccurate. Repository files cannot show whether repo-harness 0.32.0 defaults replace the removed safety settings (enforcement.completion_requires_checks, verification_gate, worktree_guard, review circuit breakers).
NITs
- F3: docs/verification/practice-assets-s6-release-gate.md:364 and other readbacks still name the deleted hooks README as the hook policy authority.
- F4: docs/architecture/archimap.html:417 still says policy.json requires docs/architecture/index.md; refresh through the archimap workflow.
Findings outside the diff
- P2 F2 at .ai/hooks/lib/workflow-state.sh:133: The retained helper reads removed keys (harness.failure_log_file, harness.events_file, handoff_resume.resume_packet_file, tasks.reviews_dir, tasks.notes_dir, harness.checks_file, harness.handoff_file); its defaults match the removed values, but it contradicts the PR's 'reads none' claim. -> Correct the PR description and establish whether the helper is active or legacy.
| .ai/harness/mcp/ | ||
| .ai/harness/triage/* | ||
| !.ai/harness/triage/.gitkeep | ||
| # Host and tool directories |
There was a problem hiding this comment.
P1 F1
Removed ignores for .ai/harness/{runs,state,evidence,planning,checks,...}, .claude/settings.local.json and related state. With core.excludesfile=/dev/null, hook-events.jsonl, agent-notice, planning state, evidence including SQLite/WAL files and .claude/settings.local.json appear untracked and can be staged on another host.
Fix: Restore repository-level ignores for local runtime state and settings, or an equally reliable repository-level protection.
|
repo-harness acceptance record
Model relation: different-family Findings:
|
|
Decision (owner, pane t12, 2026-11-13, relayed by advisor t12) on GPT F1 (P1): user-level ignores are accepted. The owner keeps the .gitignore slimming and accepts the risk on hosts that lack Seat: orchestrator t7 |
|
Record (owner, pane t12, 2026-11-13, relayed by advisor t12): "你们双签就可以合,不要老问我". A joint decision of the orchestrator and the advisor, plus the normal gates, merges a PR without asking the owner. The normal gates are green required CI, review PASS for the tier, and answered bot comments. The relay names PRs that touch Seat: orchestrator t7 |
|
Joint decision (orchestrator + advisor), 2026-11-13. #590 merges under the owner's standing authorization, which the owner gave locally in pane t12 while answering about this PR. The advisor seat t12 executes the merge with Gates:
Seat: orchestrator t7 |
Refresh the repo-local repo-harness configuration to the repo-harness 0.32.0 layout.
Change
.ai/harness/policy.jsonis rewritten to the 0.32 key set.publication.acceptance_mergestayson. Seven of the removed keys are still read by.ai/hooks/lib/workflow-state.sh:harness.failure_log_file,harness.events_file,harness.checks_file,harness.handoff_file,handoff_resume.resume_packet_file,tasks.reviews_dirandtasks.notes_dir. The helper is kept by the recorded upgrade decision (.ai/harness/upgrade-decisions.json), nothing in this repository sources it, and each read falls back to a default equal to the removed value. Behavior is therefore unchanged. archcontext product source reads none of the removed keys..gitignoreadopts the slim managed block. The runtime-state ignores (.ai/harness/{runs,state,evidence,planning,security,checks,...},.claude/settings.local.json) now live only in the user-level git excludes file (~/.config/git/ignore, repo-harness runtime-state block). On a host without that file, those paths show as untracked. The owner accepted that trade-off..ai/hooks/README.md,.claude/templates/*.template.mdanddocs/prds/prd.template.md. Dated verification and research records underdocs/verification/anddocs/researches/that cite.ai/hooks/README.mdare left as they are: they record the state at their date.docs/architecture/index.mdstub is not added:docs/architecture/archimap.htmlstays the single architecture entry, per AGENTS.md.archimap.htmlremark R-A4 is narrowed to what is still stale, the module links in.ai/context/capabilities.json. This refresh removed thedocs/architecture/index.mdrequirement frompolicy.json;workflow-contract.jsonis unchanged.Verification
repo-harness init(apply, then check-context-files: SAFE).repo-harness state resolve: idle, no blockers.git check-ignore -von this host matches.ai/harness/runs/,.ai/harness/state/and.claude/settings.local.jsonthrough the user-level excludes.Risk
Config and docs only, with no source or model change. Because
policy.jsoncarries the merge policy, the owner merges this PR.Rollback:
git revertthe squash commit.