Skip to content

ledger read mode: validateModel has no parity with YAML validation (schemas, topology, state machines) #576

Closed

Description

@Ancienttwo

Found by the GPT review of #575 (#571). Joint decision (orchestrator + advisor), 2026-11-13: this comes after 0.14.0. It is a precondition for any ledger-authoritative promotion under ADR-0050. In 0.14.0, YAML is the only authority and the default read mode.

Observed

With ARCHCONTEXT_LEDGER_READ_MODE=ledger, validateModel (runtime-daemon/src/index.ts, about :214) uses validateLedgerModelFiles (about :1401). That validator checks only the required files, the schemaVersion prefix, ADR appliesTo, constraints and the review policy. Three checks that YAML's validateModel (model-store-yaml/src/index.ts, about :299-356) runs are missing:

So a model that YAML validation rejects can validate in ledger read mode.

Requirement

Ledger read mode validates the same model the way YAML validation does. Do not patch individual checks; there must be one validation path, or a proven equivalence. Design pass first (read-only), then a work item.

Not part of #541.

Seat: orchestrator t7

Activity

  1. Ancienttwo commented on Nov 13, 2026

    @Ancienttwo
    OwnerAuthor

    Joint decision (orchestrator + advisor), 2026-11-13, on parallelizing the remaining issues. The owner asked in pane t12: "近7个issues,还有多久才能收完?能不能并行".

    1. 0.14.1 (0.14.1: unblock the repo-harness archctx 0.14 pin (#579, #580) #583, release: prepare archctx 0.14.1 #582) is in flight and finishes first. main stays frozen until the release candidate chore(release): prepare archctx 0.14.1 (#582) #591 merges. codegraph-adapter: read the index only through the in-process read-only handle #574 S1 (feat(codegraph-adapter): one in-process read-only read session (#574 S1) #589) merges after 0.14.1 is published.
    2. Started now, in parallel, in files codegraph-adapter: read the index only through the in-process read-only handle #574 does not touch:
    3. codegraph-adapter: read the index only through the in-process read-only handle #574 split. Right after S1 merges, a move-only slice S1b (Medium, one GPT review) splits codegraph-adapter/src/index.ts by responsibility: readiness and status, import population, projection handshake, snapshot, CLI provider. Behavior does not change. Then S2+S3, S4 and S5 run in parallel, each in its own module, and S6 comes last.
    4. complete: codegraph sync runs twice per complete #584 and codegraph-adapter: the 50 000 import-node read limit is reached at about 8x repo-harness #585 fold into codegraph-adapter: read the index only through the in-process read-only handle #574 S2+S3.

    Seat: orchestrator t7

  2. Ancienttwo commented on Nov 13, 2026

    @Ancienttwo
    OwnerAuthor

    Claim: writer and head owner is Pi seat t2kj (magpie Opus 5.5), on branch fix/576-one-model-validator from main 27c68b2. Tier High: one GPT review plus one Opus review. The merge waits for the 0.14.1 freeze to lift.

    Seat: orchestrator t7

  3. Ancienttwo commented on Nov 13, 2026

    @Ancienttwo
    OwnerAuthor

    repo-harness issue claim status
    Claim: #576 (comment)
    Status: ready for review; claim remains active
    PR: #593 head 22ce466
    CI: pending
    Next: the coordinator dispatches one GPT review and one Opus review; the merge waits for the 0.14.1 freeze to lift

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions