fix: hide "New" and "+" buttons for SESSION/ONE concepts in BOX<FORM> - #441
Open
stefjoosten wants to merge 1 commit into
Open
fix: hide "New" and "+" buttons for SESSION/ONE concepts in BOX<FORM>#441stefjoosten wants to merge 1 commit into
stefjoosten wants to merge 1 commit into
Conversation
SESSION and ONE are singleton concepts — only one instance ever exists.
The "New {concept}" and "+" add buttons were shown regardless, implying
the user could create new instances when they cannot.
Guard both with tgtResourceType !== "SESSION" && tgtResourceType !== "ONE".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch by @sjcjoosten (2026-08-06); PR opened to get it into the review flow.
Problem
BOX<FORM>offered a "New {concept}" button and a "+" add-icon for SESSION and ONE target concepts. Those are singleton concepts: no new instance can be created from the UI, so the buttons produced errors.Fix
Guard both buttons on
tgtResourceType !== 'SESSION' && !== 'ONE', analogous to the SESSION/ONE handling that landed via #431/#433/#434.🤖 Generated with Claude Code