generator: Fix broken union type anyOf selection since Redfish 2024.1#20
Open
Nitorac wants to merge 1 commit intoAmateurECE:developfrom
Open
generator: Fix broken union type anyOf selection since Redfish 2024.1#20Nitorac wants to merge 1 commit intoAmateurECE:developfrom
Nitorac wants to merge 1 commit intoAmateurECE:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I propose a minor fix that helps fixing the issue for union types in the OpenAPI spec after Redfish 2024.1.
In Redfish 2023.1 Resource.yaml, the Location resource looks like this:
So the redfish-generator works as expected on this structure.
But since Redfish 2024.1, it looks like this:
This leads to the UnionContextFactory to ignore this kind of resources that fallback into a simple
pub struct Location;.As a patch, I propose to still support getAnyOf if any works, but add the support for the simple .get$ref() on these resources.
I'm still pretty new with the Redfish specification so I am open for any improvements on this code !