Repository navigation
fix: address upstream review findings - #7
Merged
Merged
Conversation
…ports - Keep the separate-channel rule: base URL, platform and protocol cannot change on edit, so a stored key never reaches another upstream. - Hash derived stickiness preferences into their own namespace so they never read or rewrite explicit bindings; parent lookups stay read-only. - Mark derived affinity rows, cap them at a quarter of the table and let explicit bindings evict them first. - Charge image model output at the image rate and settle input by modality. - Read OpenCode Go usage only for channels on the official origin. - Make IP reputation lookups an explicit action, coalesce them per IP and start the cooldown when an attempt begins. - Make group names unique among active groups only so retired groups keep their names and never block deletion. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies the fixes from upstream review on murongg#160 (all eight findings): channel endpoints stay locked on edit, derived stickiness uses its own namespace and capacity, image models are priced by modality, OpenCode Go usage only for the official origin, explicit and paced IP reputation lookups, and group names unique among active groups only.
New additive migrations:
032_affinity_preferences.sql,033_group_active_names.sql(rebuildsaccount_groups; verified on a copy of a populated database).make checkpasses locally (race tests for all packages, 544 frontend tests, build).🤖 Generated with Claude Code