Repository navigation
Add Dockerfile and Datum Cloud deploy pipeline - #9
Merged
Merged
Conversation
- Add output: "standalone" to next.config.ts and a multi-stage Dockerfile (node:20-slim) -- verified end-to-end locally (build, run, headers/CSP still correct from the prior security-hardening work) - Add .github/workflows/deploy.yml: build+push to ghcr.io on push to main, then datumctl compute deploy to Datum Cloud Compute. NEXT_PUBLIC_API_URL is baked in at build time from the API_PUBLIC_URL repo variable, since Next.js inlines NEXT_PUBLIC_* vars into the client bundle at build time - Add DEPLOY.md documenting the one-time setup and what's still unverified Stacked on security-hardening (#1). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Collaborator
Author
|
Reopening to trigger CI after the base-branch retarget. |
2 tasks done
…es in dependabot Node.js shipped a security release on 2026-10-21 covering the 22.x/24.x/26.x lines (CVE-2026-111497, a HIGH-severity Brotli decoder out-of-bounds write reachable via fetch()'s auto-decompression, among others) -- 20.x isn't in that list at all, since it reached end of life in April 2026 and gets no further patches. Next.js 16 only requires Node >=20.9 as a floor, so bumping to the 22.x LTS line (currently patched) is safe. Add a dependabot "docker" ecosystem entry so a stale/EOL base image doesn't go unnoticed like this again. Verified: image builds, container runs node v22.23.4 (the just-patched version), serves /login with the expected security headers intact. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #1.
output: "standalone"tonext.config.tsand a multi-stageDockerfile-- verified end-to-end locally (build, run, security headers/CSP from Add LICENSE, security headers, CI, and OSS project docs #1 still correct).github/workflows/deploy.yml: builds and pushes toghcr.io/altsmanager/webon push tomain, then deploys to Datum Cloud Compute viadatumctl compute deployNEXT_PUBLIC_API_URLis baked in at build time from anAPI_PUBLIC_URLrepo variable (Next.js inlinesNEXT_PUBLIC_*vars into the client bundle at build time, so it can't be supplied later)DEPLOY.mdwith the one-time setup this depends onContext / open items
Same as api#12: Datum Compute access for the
altsmanagerproject is pending, and the exactdatumctl compute deploybehavior on repeat calls is unverified against a real deployment.Testing
docker build --build-arg NEXT_PUBLIC_API_URL=... .succeeds/loginwith the expected security headers/CSP intactnpm run lintandnpm run buildpassactionlintpasses on the new workflow🤖 Generated with Claude Code