__aliasMarker refactoring to cover complex cases with ALIASes (antalya-26.3) #1844
Check failed
There are 2 commits incorrectly signed off, the check did not pass.
Summary
| Sha | Message | Pass or fail reason | |
|---|---|---|---|
| 🟢 | 0bd619b | Analyzer: fix __aliasMarker | Valid sign-off found |
| 🟢 | 610d297 | Add distributed alias marker regressions | Valid sign-off found |
| 🟢 | 439ab81 | Consolidate distributed alias regression tests | Valid sign-off found |
| 🟢 | 205cd72 | Fix distributed alias marker handling | Valid sign-off found |
| 🟢 | 1ef98ae | Tighten alias marker serialization contract | Valid sign-off found |
| 🟢 | 4f6d06c | Preserve nested __aliasMarker chains across hops | Valid sign-off found |
| 🟢 | 0271d62 | Add distributed-over-distributed double alias mark... | Valid sign-off found |
| 🟢 | 321674e | Fix remote/local header remap by name when safe | Valid sign-off found |
| 🟢 | 1f62781 | Revert "Fix remote/local header remap by name when... | Valid sign-off found |
| 🟢 | 24797c4 | Add DoD regression for alias column swap with enab... | Valid sign-off found |
| 🟢 | b89d56e | tests: add DoD+parallel replicas alias column-swap... | Valid sign-off found |
| 🟢 | 86c88ed | Planner: prefer name-based conversion with positio... | Valid sign-off found |
| 🟢 | 2c1e90d | test: plain-Distributed alias column-swap reproduc... | Valid sign-off found |
| 🟢 | ad35dc2 | test: parallel-replicas alias column-swap reproduc... | Valid sign-off found |
| 🟢 | 82831da | test: natural Merge-over-Distributed alias reprodu... | Valid sign-off found |
| 🟢 | 324d41d | Fix StorageMerge alias columns over Distributed by... | Valid sign-off found |
| 🟢 | 67e461d | test: distributed alias reorder + computed-express... | Valid sign-off found |
| 🟢 | ea516c3 | test: Hybrid unknown-table regression for issues #... | Valid sign-off found |
| 🟢 | 23e8ba6 | StorageMerge: drop redundant short-name reconcilia... | Valid sign-off found |
| 🟢 | 3d20d98 | tests: remove contradictory marker-off DoD alias-s... | Valid sign-off found |
| 🟢 | e7ae515 | Address review findings on the __aliasMarker / hea... | Valid sign-off found |
| 🟢 | 15d85e5 | StorageMerge: use Nested::splitName for analyzer-i... | Valid sign-off found |
| 🟢 | 5967d5b | test: make 03928 deterministic across architecture... | Valid sign-off found |
| 🟢 | ade20aa | test: pin serialize_query_plan=0 in 03923 and 0393... | Valid sign-off found |
| 🟢 | 9ea1597 | Document enable_alias_marker escape hatch for mixe... | Valid sign-off found |
| 🟢 | a235560 | test: make 03931 parallel-replicas alias test dete... | Valid sign-off found |
| 🔴 | 907d00c | Document bucket D drop rationale + preserve SQL | Sign-off not found |
| 🟢 | e562e7d | Planner: switch name-vs-position helper to a predi... | Valid sign-off found |
| 🟢 | ea41305 | Merge remote-tracking branch 'altinity/antalya-26.... | Skipped: sign-off not required in merge commit |
| 🟢 | 956089b | Nits: clarity refactor + Nested-subcolumn TODO | Valid sign-off found |
| 🟢 | b4fb40c | StorageMerge: emit alias outputs under analyzer id... | Valid sign-off found |
| 🔴 | b178014 | Planner: include column-name lists in Position-fal... | Sign-off not found |
| 🟢 | 2cb9bd9 | StorageMerge: accept raw-dot dotted ALIAS identifi... | Valid sign-off found |
Errors details
Sign-off not found
No sign-off was found in the commit message. This usually means that the author or committer of this commit failed to include a Signed-off-by line in the commit message. In some cases, this error can also be raised if the sign-off is not in the correct format.
To avoid having pull requests blocked in the future, always include a Signed-off-by: User1 <user1@email.test> line in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).
How to fix missing or invalid sign-offs
Option 1: add remediation commit
Option 2: fix commits without sign-off
Rebase the branch
If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").
Warning
You should only do this if:
- You are the only author of the commits in this branch
- You are absolutely certain nobody else is doing any work based upon this branch
- There are no empty commits in the branch
To add your Signed-off-by line to every commit in this branch:
- Ensure you have a local copy of your branch by checking out the pull request locally via command line.
- In your local branch, run:
git rebase HEAD~33 --signoff - Force push your changes to overwrite the branch:
git push --force-with-lease origin feature/antalya-26.3/alias_marker_fixes