Conversation
…nts-when-a-daily-task-is-cancelled # Conflicts: # src/__tests__/dailyTasks/formAnInnerConnection.test.ts
EemeliJ
requested review from
CapoMK25,
Iir0R,
MikhailDeriabin,
hoan301298,
psykkis and
tickBit
as code owners
October 1, 2026 09:45
Codecov Report❌ Patch coverage is
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
tickBit
reviewed
Oct 1, 2026
| ); | ||
| if (unreserveErrors) return cancelTransaction(newSession, unreserveErrors); | ||
|
|
||
| return endTransaction(newSession, wasUnreserved); |
Collaborator
There was a problem hiding this comment.
Just wondering, that should this be asynchronous return statement like this:
return await endTransaction(newSession, wasUnreserved);
I noticed, that elsewhere in the code base we have used statements like that.
tickBit
reviewed
Oct 1, 2026
| TASK_CONSTS.POINTS.DAILY_TASK.CANCEL_PENALTY, | ||
| session, | ||
| ); | ||
| if (deductionErrors) return cancelTransaction(session, deductionErrors); |
tickBit
requested changes
Oct 1, 2026
tickBit
left a comment
Collaborator
There was a problem hiding this comment.
I think it would safer to use await in those return statements.
Please include also some output from testing the implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief description
Adds a 10 point (regular) penalty when a player relinquishes an active daily task. The penalty is applied when unreserving, switching to another task, or deleting an owned task. Released tasks return to the pool as fresh tasks, and all cancellation changes run transactionally.
Change list
TASK_CONSTS.POINTS.DAILY_TASK.CANCEL_PENALTYfrom regular player points.closes #996