Add Theme Toggling with Ant Design CSS and LocalStorage Persistence - #14
Open
smdbs01 wants to merge 2 commits into
Open
Add Theme Toggling with Ant Design CSS and LocalStorage Persistence#14smdbs01 wants to merge 2 commits into
smdbs01 wants to merge 2 commits into
Conversation
…ate Login page to pass pre-commit check
smdbs01
marked this pull request as ready for review
November 24, 2024 07:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Done
Serve both light and dark Ant Design CSS files from the
publicfolder. Implement theme toggling using JoseRFelix/react-css-theme-switcher, with user preferences stored inlocalStoragefor basic persistence.This PR fixes issue #6.
Noteworthy Changes
package.json:4.24.1was installed, suggesting that the^5.17.0specifier was an unintended change.<=5.1.32as versions5.1.33+introduced breaking changes (see StackOverflow).Future Improvements
darkclass to thehtmltag when Dark Mode is preferred. Non-Ant Design components can now adopt the dark theme using CSS variables by defining values in:rootand:root.dark.