wxdragon-sys: switch reqwest TLS from rustls to native-tls#154
Merged
Conversation
Fixes AllenDang#153. Replaces the `rustls` + `socks` features on the reqwest build dependency with `native-tls`, delegating TLS to the OS on each platform. This eliminates two CMake-based C compilation steps (aws-lc-sys, ring) and removes ~42 transitive crates from the build graph. On Linux, libssl-dev is already a documented build requirement since 74eb0d7 (WebKitGTK), so there is no regression in toolchain requirements. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #153.
wxdragon-sysusesreqwestas a build dependency to download the wxWidgets zip archive during the initial build. The previous configuration usedrustls, which pulls inaws-lc-sysandring— both require CMake and C compilation, adding significant overhead to every fresh build.This PR switches to
native-tls, delegating TLS to the OS TLS stack on each platform:libssl-devsince 74eb0d7 (WebKitGTK)The
socksfeature is also dropped — proxy support for a fixed-URL download is unnecessary (HTTP proxy viagit config http.proxycontinues to work as before).Impact
aws-lc-sys,ring,quinn,rustls, and the full JNI/Android stack pulled in byrustls-platform-verifierChange
🤖 Generated with Claude Code