Adds customization of cropper color and limit black overlay to image only#47
Open
faltakam wants to merge 3 commits into
Open
Adds customization of cropper color and limit black overlay to image only#47faltakam wants to merge 3 commits into
faltakam wants to merge 3 commits into
Conversation
faltakam
commented
Oct 6, 2015
- Original color of cropper color boundaries is set as default value.
- Black overlay stripes on sides, which appear when image aspect ration doesn't match canvas aspect ratio, can be confusing when image background color is the same as background color of canvas parent element. In that case image borders aren't visible and stripes that fill canvas appear to be part of the image. When resizing or moving crop you are restricted to image only but due to invisible image borders it appears that some part of image is inaccessible. Limiting overlay to image only fixes the issue.
|
Useful feature, code looking good, hope Allan can merge this soon? |
|
+1 :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.