refactor: move shared code to public tvs-lib crate - #66
Conversation
ryan-berger
left a comment
There was a problem hiding this comment.
+600 is hard to review, but from what I gather this is mostly copying a bunch of code over, with some extra utilities that need sharing which makes this an easy +1.
From a philisophical point of view, I think that we are going to have some tension with this library-ification PRs for a bit before we standardize the interface. Right now we want to make as many things common as needed/as we see fit, but as future library maintainers we will want to hide as much functionality behind our interface as possible.
So long as we can make lots of breaking changes, I think we're good to go.
|
Yeah, it's just moving code around.
Yeah, totally agree. |
No description provided.