Skip to content

refactor: move shared code to public tvs-lib crate - #66

Merged
tombh merged 3 commits into
mainfrom
tombh/tvs-lib
Jun 8, 2026
Merged

refactor: move shared code to public tvs-lib crate#66
tombh merged 3 commits into
mainfrom
tombh/tvs-lib

Conversation

@tombh

@tombh tombh commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@tombh
tombh requested a review from ryan-berger June 5, 2026 14:32

@ryan-berger ryan-berger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+600 is hard to review, but from what I gather this is mostly copying a bunch of code over, with some extra utilities that need sharing which makes this an easy +1.

From a philisophical point of view, I think that we are going to have some tension with this library-ification PRs for a bit before we standardize the interface. Right now we want to make as many things common as needed/as we see fit, but as future library maintainers we will want to hide as much functionality behind our interface as possible.

So long as we can make lots of breaking changes, I think we're good to go.

@tombh

tombh commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator Author

Yeah, it's just moving code around.

Right now we want to make as many things common as needed/as we see fit, but as future library maintainers we will want to hide as much functionality behind our interface as possible.

Yeah, totally agree.

@tombh
tombh merged commit 7d7fdf9 into main Jun 8, 2026
4 checks passed
@tombh
tombh deleted the tombh/tvs-lib branch June 8, 2026 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants