Disallow non-centred tiles and remove --scale argument - #56
Merged
Conversation
There's probably a way for us to support non-centred tiles in the application, but for now it's best to just disallow them. Non-centred tiles compute fine but their final geo referencing causes misalignment if displayed on a global map.
tombh
force-pushed
the
tombh/disallow-non-centred-tiles
branch
from
April 22, 2026 15:11
7501fed to
4a89808
Compare
ryan-berger
approved these changes
Apr 25, 2026
ryan-berger
left a comment
ryan-berger
left a comment
Member
There was a problem hiding this comment.
It would be nice to have an integration test, but since it is the CLI that's a bit hard
When creating tiles that are not at exactly 100m resolution their centres are often off by a few fractions of a milimetre. Which should be allowed.
tombh
changed the title
--scale argument
tombh
force-pushed
the
tombh/disallow-non-centred-tiles
branch
from
April 26, 2026 10:29
967289e to
cbf740d
Compare
tombh
added a commit
to AllTheLines/viewview
that referenced
this pull request
Apr 26, 2026
We support GeoTiffs now so the scale always comes from the tile.
tombh
force-pushed
the
tombh/disallow-non-centred-tiles
branch
from
April 26, 2026 10:33
cbf740d to
7967ab8
Compare
Collaborator
Author
|
I added a test. I've also used this PR to remove the And I've pushed the viewview side of this AllTheLines/viewview#81 |
tombh
added a commit
to AllTheLines/viewview
that referenced
this pull request
Apr 26, 2026
tombh
added a commit
to AllTheLines/viewview
that referenced
this pull request
Apr 26, 2026
ryan-berger
approved these changes
Apr 26, 2026
ryan-berger
left a comment
ryan-berger
left a comment
Member
There was a problem hiding this comment.
Looks good! Glad that we can stop ourselves from accidentally running on a tile without it being centered
tombh
added a commit
to AllTheLines/viewview
that referenced
this pull request
Apr 28, 2026
tombh
added a commit
to AllTheLines/viewview
that referenced
this pull request
May 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's probably a way for us to support non-centred tiles in the
application, but for now it's best to just disallow them.
Non-centred tiles compute fine but their final geo referencing causes
misalignment if displayed on a global map.