Repository navigation
ci(workflow): ♻️ move pages‑artifact upload into build job & simplify deploy condition - #9
Merged
Conversation
… deploy condition - Move `actions/upload-pages-artifact` step from deploy job to build job - Simplify deploy‑job if‑condition, remove redundant branch check: Top‑level `on.push.branches:[main]` already restricts push events to main branch New condition: `github.event_name == 'push' || github.event_name == 'workflow_dispatch'` - Keep existing concurrency rules, build logic, docs copy and ls debug output unchanged - Build and deploy are still separate jobs, pages artifact is produced inside build runner Eliminate redundant branch judgment, adapt to official pages artifact workflow. No related issues
Skixkk
commented
Aug 16, 2026
Skixkk
left a comment
Skixkk
left a comment
Collaborator
Author
There was a problem hiding this comment.
Pages artifact moved to build job, deploy condition simplified.
Checklist:
- upload‑pages‑artifact inside build
- Redundant branch check removed
- Existing build logic kept
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
actions/upload-pages-artifactfrom deploy job to build jobgithub.ref == 'refs/heads/main'branch filterThe top‑level trigger
on.push.branches: [main]already guarantees push events only originate from main branchPurpose
Remove unnecessary branch condition, conform to artifact upload‑deploy workflow for GitHub Pages.
Impact
Only workflow yaml is modified, source code unchanged.