comfyui-mcp: stop baking generate_song workflow into the image#70
Merged
Conversation
The song workflow was baked at /app/workflows/generate_song.json (originally the upstream v1 3.5b graph, which hardcoded a model and used image-gen sampler defaults that produced low-quality output). Remove it so nothing song-specific is baked: skills/agents now compose the graph and submit it via queue_prompt(workflow_json=...), keeping the workflow as editable data (operators own the model/params) rather than an image rebuild. Matches how generate_image was already handled. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The ComfyUI code is the bind-mounted git checkout (data/comfyui-storage/ComfyUI), not the image; note the version floor + rollback command so a fresh clone knows XL song generation needs >= 0.19.0. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the baked
generate_song.jsonfrom the comfyui-mcp image. Nothing song-specific is baked anymore — skills/agents compose the ComfyUI graph and submit it via the existingqueue_prompt(workflow_json=...)tool.Why
The baked workflow was the upstream v1 3.5b graph: it hardcoded a model and used image-generation sampler defaults (20 steps / cfg 8), which produced low-quality songs. Baking also meant every model/param change required an image rebuild.
Making the workflow data (owned by the operator, passed as an argument) means:
generate_image.jsonis already stripped.The operator's song workflow (ACE-Step 1.5 XL SFT) now lives in Hermes' private data and is submitted through
queue_prompt.Note
Requires ComfyUI >= 0.19.0 for ACE-Step 1.5 XL support (tracked separately as a runtime version bump, not part of this image change).
🤖 Generated with Claude Code