Repository navigation
feat(ui-egui): font name and size combo boxes, OneNote whole sizes - #97
Merged
Merged
Conversation
The size list now offers OneNote's whole sizes (8 to 72, 16 sizes) and drops the " pt" text. 9.5 and 10.5 wait for a page-format change, since the page stores whole sizes. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Font name and font size become OneNote-style combo boxes: an editable box showing the current value, and a drop-down arrow whose list opens under the box, highlights the current value and scrolls to it. The shared control lives in combo.rs. The font name sits beside the size, and the font list is read on a background thread. Windows also reads the per-user font folder. With no caret in the page the boxes show the base size and Default, and a choice made with no caret applies to the next typed text. Known gaps: typing a size does not apply it yet (the box loses the page selection on focus); the floating tools group has no font boxes yet. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Main added an inline field to Caret. The helper that places the caret for a font or size choice now sets it to None. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
On Linux and macOS nothing calls load_fonts_folder, so clippy with warnings denied failed on the CI runner. It is now built for Windows and tests only. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
crates/ui-egui/src/combo.rs.Known gaps
craft-uireuse is on hold.Checks
cargo xtask ci: all checks passed on the branch rebased ontoorigin/main.🤖 Generated with Claude Code