Repository navigation
fix(ui-egui): direction icons show the arrow alone, as OneNote does - #94
Merged
Merged
Conversation
The arrow head sits to the right of the pilcrow and points left, as in OneNote. A failing test first showed the arrow at x 3 and the pilcrow at x 23. The paired visual reference is updated to the same geometry. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
The owner asked for the arrow a little higher and spaced, as Word has it. The head moves up 5 points and its tip moves 1 point right, so there is a 3 point gap from the pilcrow stem. The paired reference matches. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
The LTR direction icon's arrow head moves up 5 points, level with the RTL icon's, so the pair reads as one set. A failing test came first. The paired reference matches. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
The LTR arrow head was 4 points wide and the RTL one 3. The LTR tip moves in by one point, so both heads are 3 by 6 points. A failing test came first, and the paired reference matches. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
The owner asked for a larger arrow head and a smaller pilcrow. The pilcrow is scaled to 85 percent of its size and the arrow head is 4 by 8 points. The LTR icon mirrors the RTL one. Tests were written first, and the paired reference matches. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
The owner asked for the pilcrow to keep its size and shape. The arrow head's position and direction now carry the paragraph direction. The RTL pilcrow moves left to leave room for the arrow, and the LTR pilcrow keeps its original place. A test checks that the pilcrow is not mirrored. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Direction icons for paragraph direction (
ParaRtl,ParaLtr) now show the direction with the arrow head alone, as OneNote and Word do:Tests
crates/ui-egui/src/icons.rs(written first, seen to fail): arrow position and spacing, arrow size, arrow height, pilcrow size, and no mirrored pilcrow.crates/ui-egui/tests/icons_visual.rsis updated to the same geometry. The paired test requires production and reference to match pixel for pixel.Checks
cargo xtask ci: all checks passed, on the branch rebased ontoorigin/main(74be4ad).🤖 Generated with Claude Code