Repository navigation
feat(ui-egui): Draw > Collect All gathers what drifted apart (#23) - #237
Merged
Merged
Conversation
…chSoftware#23) A Collect All button at the end of the Draw tab's Edit group pulls the boxes and strokes of ink that drifted apart on the open canvas back together. Along each axis, every empty stretch of the page wider than a small gap (24 pt), including the margin before the first item, is closed down to that gap. Nothing else moves. Items keep their order across and down the page, and nothing ends up on anything it was not already on. Ink drawn over a box moves with the box, so notes keep their annotations. One Undo puts the boxes and the ink back together. The new layout is written to the page like any other box move. collect.rs holds the geometry, with unit tests. containers::Moved now reports each box's frame in page points, and inkpad::Pad gains stroke_bounds and move_each. Closes AlienTechSoftware#23 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y4im4nvZvQHZdShop1ff8w
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #23.
What changes
A Collect All button at the end of the Draw tab's Edit group pulls the boxes and strokes of ink that drifted apart on the open canvas back into a close group.
Code
crates/ui-egui/src/collect.rs:gather(items, gap), the geometry, with unit tests for far-apart items, small gaps, overlap safety, ordering and junk input.containers::Moved.frames: each box's frame in page points (normal and ink views).inkpad::Pad::stroke_bounds/move_each.docs/gaps.mddescribes the command under Pen and drawing.Tests
collect_all_gathers_boxes_and_ink_that_drifted_apartputs two boxes at (40,20) and (3000,2500) and draws one stroke far down the page. It then runs Collect All and checks:cargo xtask cipasses locally.🤖 Generated with Claude Code
https://claude.ai/code/session_01Y4im4nvZvQHZdShop1ff8w