Repository navigation
feat(ui-egui): Insert Space drags room into the page (#164) - #229
Merged
Merged
Conversation
…re#164) Insert > Insert Space put one blank paragraph after the caret. It is now OneNote's tool: with it in hand, the page shows a guide at the pointer's height and a vertical-resize pointer, and a drag moves every box and every ink stroke that starts below where the drag began, down by as far as it went. A drag up takes room away, never past the top of the page. The band of room is shown while dragging. One drag, then the tool is put down; Esc puts it down without a change. The boxes move the way a dragged box does, so the page keeps the new arrangement and Undo takes the room back out. The ink moves with them (Pad::shift_below). The tool sits in a foreground area of its own, so the drag does not reach the words, the boxes or the pen underneath. ui.inspect reports whether it is in hand. The blank-paragraph action is kept for the code that still uses it, but the ribbon button is the tool. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y4im4nvZvQHZdShop1ff8w
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Closes #164. Insert > Insert Space put one blank paragraph after the caret. There was no drag, no preview, and no way to close a gap. It is now OneNote's tool:
How:
insert_space_overlayinapp.rs). The drag never reaches the words, the boxes or the ink layer underneath.moved.boxes), so the page keeps the new arrangement in its file and Undo takes the room back out (redo puts it back).Pad::shift_below.ui.inspectreportscanvas.insertSpace. New strings are inen,en-XAandar-XB.docs/gaps.mddescribes the tool and its one limit, the same as OneNote's: it moves boxes. It does not open a gap between two lines inside one box.The old blank-paragraph action (
Act::Insert("space")) is still there for the code and tests that use it, but the ribbon button is now the tool.Quality level L3 (see SKILLS/nc-devx/SKILL.md)
mainand has no merge commitscargo xtask cipassescoveragejob's warnings are read (CI)docs/gaps.mdCommandSpecwith a test: the tool changes the box arrangement through the same path as dragging a box, which is saved withpage.containersassets/ordocs/images/(none)How it was checked
UI test
insert_space_drags_room_into_the_page_and_out_again, on the sample page arranged in two boxes (y = 20 and 500) with an ink stroke between them:page.containerskeeps40,600,320.The captured picture was reviewed.
cargo xtask cipassed locally.🤖 Generated with Claude Code
https://claude.ai/code/session_01Y4im4nvZvQHZdShop1ff8w