Skip to content

Event Display: remove return statements from handled filesystem exceptions #14948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ehellbar wants to merge 1 commit into
base: dev
Choose a base branch
from
+0 −3
Open

Event Display: remove return statements from handled filesystem exceptions #14948

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions EventVisualisation/Base/src/DirectoryLoader.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ deque<string> DirectoryLoader::load(const std::string& path, const std::string&
}
} catch (std::filesystem::filesystem_error const& ex) {
LOGF(error, "filesystem problem during DirectoryLoader::load: %s", ex.what());
return result;
}
// comparison with safety if marker not in the filename (-1+1 gives 0)
std::sort(result.begin(), result.end(),
Expand All @@ -62,7 +61,6 @@ bool DirectoryLoader::canCreateNextFile(const std::vector<std::string>& paths, c
}
} catch (std::filesystem::filesystem_error const& ex) {
LOGF(error, "filesystem problem during DirectoryLoader::canCreateNextFile: %s", ex.what());
return false;
}
}

Expand Down Expand Up @@ -103,7 +101,6 @@ deque<string> DirectoryLoader::load(const std::vector<std::string>& paths, const
}
} catch (std::filesystem::filesystem_error const& ex) {
LOGF(error, "filesystem problem during DirectoryLoader::load: %s", ex.what());
return result;
}
// comparison with safety if marker not in the filename (-1+1 gives 0)
std::sort(result.begin(), result.end(),
Expand Down