Open
Conversation
LostPointer
requested changes
Feb 24, 2024
task_01/src/test.cpp
Outdated
| #include "utils.hpp" | ||
|
|
||
| TEST(utils, Simple) { | ||
| ASSERT_EQ(Task1(9, std::vector < int > {1, 2, 4, 5, 6, 8, 10, 12}), (std::pair < int, int > {1,8})); |
LostPointer
requested changes
Mar 2, 2024
task_01/src/utils.cpp
Outdated
|
|
||
| std::pair<int, int> Task1(int num, const std::vector<int> arr) { | ||
| if (arr.size() < 2) { | ||
| throw WrongVector(""); |
Contributor
There was a problem hiding this comment.
давай в исключение добавим какую-то информацию (передадим в конструктор строку)
LostPointer
reviewed
Mar 23, 2024
Contributor
|
формат упал |
LostPointer
requested changes
Mar 30, 2024
task_01/src/utils.cpp
Outdated
| #include <utility> | ||
| #include <vector> | ||
|
|
||
| std::pair<int, int> Task1(int num, const std::vector<int> arr) { |
Contributor
There was a problem hiding this comment.
давай придумаем название по лучше для функции
Contributor
There was a problem hiding this comment.
задачи 2-8 должны быть в отдельном ПР
LostPointer
requested changes
Mar 30, 2024
task_01/src/utils.cpp
Outdated
| #include <utility> | ||
| #include <vector> | ||
|
|
||
| std::pair<int, int> Sum_Of_Elements(int num, const std::vector<int> arr) { |
Contributor
There was a problem hiding this comment.
SumOfElements по кодстайлу
Contributor
There was a problem hiding this comment.
решение задач с 2 по 8 нужно унести в дргуой пулл реквест
Contributor
Author
|
да, уже переместил, просто изначально начал уже работать по ошибке в этой ветке, поэтому то что, сделал, я не знаю можно ли как-то убрать из этой ветки--Отправлено из мобильной Яндекс Почты30.03.2024, 13:37, "Ivan Khokhlov" ***@***.***>:
@LostPointer requested changes on this pull request.
In task_01/src/utils.cpp:
@@ -0,0 +1,21 @@
+#include "utils.hpp"
+#include <iostream>
+#include <utility>
+#include <vector>
+
+std::pair<int, int> Sum_Of_Elements(int num, const std::vector<int> arr) {
SumOfElements по кодстайлу
On task_03/src/test.cpp:
решение задач с 2 по 8 нужно унести в дргуой пулл реквест
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
LostPointer
approved these changes
Apr 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.