Skip to content

Finalised fix for the android 16+ Modded #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kristijanWolff wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Finalised fix for the android 16+ Modded #332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5c6cf6b
Update ModsMenu.gd
kristijanWolff May 28, 2026
d8ee1dd
Update LoadGameScreen.gd
kristijanWolff May 28, 2026
bdf5b47
Update GlobalRegistry.gd
kristijanWolff May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions GlobalRegistry.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,8 +327,8 @@ func getModsFolder() -> String:
if(OS.get_name() == "Android"):
#var permissions: Array = OS.get_granted_permissions() #for Godot 3 branch
#if permissions.has("android.permission.READ_EXTERNAL_STORAGE"):
var externalDir:String = OS.get_system_dir(OS.SYSTEM_DIR_DOCUMENTS)
var finalDir = externalDir.plus_file("BDCCMods")
var externalDir:String = "user://"
var finalDir = externalDir.plus_file("mods")
modsFolder = finalDir
var _ok = Directory.new().make_dir(modsFolder)
return modsFolder
Expand All @@ -338,8 +338,8 @@ func getDatapacksFolder() -> String:
if(OS.get_name() == "Android"):
#var permissions: Array = OS.get_granted_permissions() #for Godot 3 branch
#if permissions.has("android.permission.READ_EXTERNAL_STORAGE"):
var externalDir:String = OS.get_system_dir(OS.SYSTEM_DIR_DOCUMENTS)
var finalDir = externalDir.plus_file("BDCCMods/Datapacks")
var externalDir:String = "user://"
var finalDir = externalDir.plus_file("datapacks")
modsFolder = finalDir
var _ok = Directory.new().make_dir(modsFolder)
return modsFolder
Expand Down Expand Up @@ -2248,8 +2248,8 @@ func getSkinsAllKeys():
func findCustomSkins():
var skinsFolder = "user://custom_skins"
if(OS.get_name() == "Android"):
var externalDir:String = OS.get_system_dir(OS.SYSTEM_DIR_DOCUMENTS)
var finalDir = externalDir.plus_file("BDCCMods/custom_skins")
var externalDir:String = "user://"
var finalDir = externalDir.plus_file("custom_skins")
skinsFolder = finalDir

for skinPath in Util.getFilesInFolder(skinsFolder):
Expand All @@ -2260,8 +2260,6 @@ func findCustomSkins():
customSkin.setTexturePath(skinPath)
skins[customSkin.id] = customSkin



func registerPartSkin(path: String, authorOverride = ""):
var loadedClass = load(path)
var object = loadedClass.new()
Expand Down
91 changes: 55 additions & 36 deletions UI/MainMenu/LoadGameScreen.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ var currentExportedPath = ""
signal in_focus

func _ready():
# Automatically setup our public folder structure on launch
ensure_external_save_folder_exists()
updateSaves()

if(OS.get_name() == "Android"):
Expand All @@ -18,7 +20,16 @@ func _ready():

if OS.get_name() == "HTML5" and OS.has_feature("JavaScript"):
_define_js()


func ensure_external_save_folder_exists():
if OS.get_name() == "Android":
var download_path = OS.get_system_dir(OS.SYSTEM_DIR_DOWNLOADS) + "/"
var target_folder = download_path + "BDCCSaves/"

var dir = Directory.new()
if not dir.dir_exists(target_folder):
dir.make_dir_recursive(target_folder)

func updateSaves():
Util.delete_children(savesContainer)

Expand Down Expand Up @@ -68,21 +79,8 @@ func onExportButtonClicked(savePath: String):
return

if(OS.get_name() == "Android"):
# var has_permissions: bool = false
# while not has_permissions:
# #var permissions = OS.get_granted_permissions()
# var permissions: Array = OS.get_granted_permissions() #for Godot 3 branch
#
# if not permissions.has("android.permission.READ_EXTERNAL_STORAGE") \
# or not permissions.has("android.permission.WRITE_EXTERNAL_STORAGE"):
# var _ok = OS.request_permissions()
# #await get_tree().create_timer(1).timeout
# yield(get_tree().create_timer(1), "timeout") #for Godot 3 branch
# else:
# has_permissions = true

var d = Directory.new()
var externalDir:String = OS.get_system_dir(OS.SYSTEM_DIR_DOCUMENTS)
var externalDir:String = OS.get_system_dir(OS.SYSTEM_DIR_DOWNLOADS)
var finalDir = externalDir.plus_file("BDCCSaves/")
d.make_dir_recursive(finalDir)
var finalPath = finalDir.plus_file(savePath.get_file())
Expand Down Expand Up @@ -168,35 +166,56 @@ func readSaveFileHTML5():

return [file_name, file_data]


func _on_ImportButton_pressed():
if OS.get_name() == "HTML5":
var saveDataAndFileName = yield(readSaveFileHTML5(), "completed")
if(saveDataAndFileName == null || saveDataAndFileName.size() != 2):
return
SAVE.saveGameFromText(saveDataAndFileName[0], saveDataAndFileName[1])
updateSaves()
else:
if(OS.get_name() == "Android"):
# var has_permissions: bool = false
#
# while not has_permissions:
# #var permissions = OS.get_granted_permissions()
# var permissions: Array = OS.get_granted_permissions() #for Godot 3 branch
#
# if not permissions.has("android.permission.READ_EXTERNAL_STORAGE") \
# or not permissions.has("android.permission.WRITE_EXTERNAL_STORAGE"):
# var _ok = OS.request_permissions()
# #await get_tree().create_timer(1).timeout
# yield(get_tree().create_timer(1), "timeout") #for Godot 3 branch
# else:
# has_permissions = true
elif OS.get_name() == "Android":
var external_folder = OS.get_system_dir(OS.SYSTEM_DIR_DOWNLOADS) + "/BDCCSaves/"
var internal_save_path = "user://saves/"

var d = Directory.new()
var externalDir:String = OS.get_system_dir(OS.SYSTEM_DIR_DOCUMENTS)
var finalDir = externalDir.plus_file("BDCCSaves")
d.make_dir_recursive(finalDir)
$ImportSaveDialog.current_dir = finalDir
var dir = Directory.new()

# Ensure internal path is fully prepared
if not dir.dir_exists(internal_save_path):
dir.make_dir_recursive(internal_save_path)

if dir.open(external_folder) == OK:
dir.list_dir_begin(true)
var file_name = dir.get_next()

var success_count = 0

while file_name != "":
if not dir.current_is_dir() and file_name.ends_with(".save"):
var source = external_folder + file_name
var destination = internal_save_path + file_name

if dir.copy(source, destination) == OK:
success_count += 1

file_name = dir.get_next()
dir.list_dir_end()

# Force visual update so user instantly sees new options
updateSaves()

# Give a nice system pop up confirming success
if success_count > 0:
$SaveExportedAlert.dialog_text = "Successfully imported " + str(success_count) + " save files!"
$SaveExportedAlert.window_title = "Import Complete"
$SaveExportedAlert.popup_centered()
else:
$SaveExportedAlert.dialog_text = "No custom files ending in .save were found in Download/BDCCSaves/"
$SaveExportedAlert.window_title = "Import Empty"
$SaveExportedAlert.popup_centered()
else:
print("Error: Could not scan target directory.")
else:
# Keep original file fallback behavior active for desktop machines
$ImportSaveDialog.popup_centered()

func _on_ImportSaveDialog_file_selected(path: String):
Expand Down
79 changes: 52 additions & 27 deletions UI/ModsMenu/ModsMenu.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,15 @@ func _ready():

if(OS.get_name() == "Android"):
$VBoxContainer/GridContainer/ModsFolderButton.setIsDisabled(true)
$VBoxContainer/GridContainer/RemoveModsButton.setIsDisabled(true)
# Keep this enabled so Android users can delete their imported mods!
$VBoxContainer/GridContainer/RemoveModsButton.setIsDisabled(false)
ensure_external_mods_folder_exists()

if OS.get_name() == "HTML5" and OS.has_feature("JavaScript"):
_define_js()

var text = "[b][url=https://github.com/Alexofp/BDCC/wiki/How-to-install-BDCC-mods]How to install mods (click me)[/url][/b]\n\nTo install a mod drag it into the mods folder and restart the game. Mods are loaded in alphabetical order.\n\n"
# UPDATED: Changed the text instruction to match your new custom Download folder system!
var text = "[b][url=https://github.com/Alexofp/BDCC/wiki/How-to-install-BDCC-mods]How to install mods (click me)[/url][/b]\n\nTo install a mod, drag it into your phone's public folder: [color=yellow]Download/BDCCMods/[/color] and press the Import Mod button. Mods downloaded from the in-game browser are saved here automatically.\n"
if(!GlobalRegistry.hasModSupport()):
text += "! Mods aren't supported when running the game from the editor, this is godot issue. Export the game and run it standalone to get mod support !\n\n"
# read more here: https://github.com/godotengine/godot/issues/19815
Expand All @@ -45,6 +48,15 @@ func _ready():

modsLabel.bbcode_text = text

func ensure_external_mods_folder_exists():
if OS.get_name() == "Android":
var download_path = OS.get_system_dir(OS.SYSTEM_DIR_DOWNLOADS) + "/"
var target_folder = download_path + "BDCCMods/"

var dir = Directory.new()
if not dir.dir_exists(target_folder):
dir.make_dir_recursive(target_folder)

func _on_CloseButton_pressed():
emit_signal("onClosePressed")

Expand Down Expand Up @@ -142,31 +154,44 @@ func _on_AddModButton_pressed():
if(!showedModDialog):
showedModDialog = true
$ModAcceptDialog.visible = true
else:
if(OS.get_name() == "Android"):
# var has_permissions: bool = false
#
# while not has_permissions:
# #var permissions = OS.get_granted_permissions()
# var permissions: Array = OS.get_granted_permissions() #for Godot 3 branch
#
# if not permissions.has("android.permission.READ_EXTERNAL_STORAGE") \
# or not permissions.has("android.permission.WRITE_EXTERNAL_STORAGE"):
# var _ok = OS.request_permissions()
# #await get_tree().create_timer(1).timeout
# yield(get_tree().create_timer(1), "timeout") #for Godot 3 branch
# else:
# has_permissions = true

var d = Directory.new()
var externalDir:String = OS.get_system_dir(OS.SYSTEM_DIR_DOCUMENTS)
var finalDir = externalDir.plus_file("BDCCMods")
d.make_dir_recursive(finalDir)
#$ImportModDialog.current_dir = finalDir
$AndroidPathAlert.dialog_text = "Mods on android are loaded from:\n"+finalDir+"\nPlace them there and restart the game."
$AndroidPathAlert.popup_centered()
return
elif OS.get_name() == "Android":
var external_folder = OS.get_system_dir(OS.SYSTEM_DIR_DOWNLOADS) + "/BDCCMods/"
var internal_mod_path = "user://mods/"

var dir = Directory.new()

# Make sure internal sandbox mod folder exists
if not dir.dir_exists(internal_mod_path):
dir.make_dir_recursive(internal_mod_path)

if dir.open(external_folder) == OK:
dir.list_dir_begin(true)
var file_name = dir.get_next()

var success_count = 0

while file_name != "":
if not dir.current_is_dir() and (file_name.ends_with(".zip") or file_name.ends_with(".pck")):
var source = external_folder + file_name
var destination = internal_mod_path + file_name

if dir.copy(source, destination) == OK:
success_count += 1

file_name = dir.get_next()
dir.list_dir_end()

if success_count > 0:
$AndroidPathAlert.dialog_text = "Successfully imported " + str(success_count) + " mod files!\nRestart the game to apply them."
$AndroidPathAlert.window_title = "Import Complete"
$AndroidPathAlert.popup_centered()
else:
$AndroidPathAlert.dialog_text = "No files ending in .zip or .pck were found in Download/BDCCMods/"
$AndroidPathAlert.window_title = "Import Empty"
$AndroidPathAlert.popup_centered()
else:
print("Error: Could not scan external mods directory.")
else:
$ImportModDialog.popup_centered()


Expand Down Expand Up @@ -204,7 +229,7 @@ func _on_ModsLabel_meta_clicked(meta):

func _on_SkinsFolderButton_pressed():
if(OS.get_name() == "Android"):
$AndroidPathAlert.dialog_text = "Custom skins on android are loaded from \"Documents/BDCCMods/custom_skins\"\nCreate that folder if it doesn't exist."
$AndroidPathAlert.dialog_text = "Custom skins on android are loaded from \"Download/BDCCMods/custom_skins\"\nCreate that folder if it doesn't exist."
$AndroidPathAlert.popup_centered()
else:
var _ok = Util.fixed_shell_open(ProjectSettings.globalize_path("user://custom_skins"))