fix #303 NPCs locked in Stocks magically restore Stamina to 100% after 'Use'

[Zsar]

fixed for Stocks, TODO:

• deduplicate (or at least fix separately) Slutwall - actually works fine and now I cannot reproduce them ignoring Stamina when I go back to HEAD~1 either...
  Guess I can drop 3bc120a then.
• further verify nothing else broke

[Alexofp]

There are too many unrelated changes, why change the function definitions and stuff if you're just fixing one thing x3
I also dunno if all the other changes gonna break anything. I can only guess

[Zsar]

Sorry, I guess.

It is inconceivable to me that anyone would want to memorise all this information, when they could simply write it down and have the tools help with not making mistakes, which were specifically designed to... help with not making mistakes.

(And of course, I, who I am not familiar with it need to find this information from somewhere, and the IDE is no help: Rider only deduces these up to a few (2?) steps and then it gives up. The Godot editor does not even seem to try.)

But it's your project. Reverting.

[Alexofp]

I'm sorry if I sound mean, didn't mean to. I'm tired, sorry x3
I appreciate the help, just don't have the capacity to think about this stuff currently. I could just fix it myself when I get into the mood

[Zsar]

No harm done.

And please, do feel free to let me wait for as long as you want to or need to - I am only doing this right now, because I myself have the time right now.
The platform is asynchronous by design and it is good that way.

I do not mind digging into this as a way to get to grasps with Godot without having to roll my own project from scratch... but, well, Godot and particularly GDScript seem to be specifically designed to make contributing hard. (Reading and understanding the source, that is. Necessary precondition for having anything to contribute.)

Maybe, once you have some time and mental energy for it, you could add a CONTRIBUTING.md to the repository re. type hints and similar coding guidelines. I saw that you had started - relatively late in development - to add and retrofit type hints yourself and thus expected that I should do the same - which is very sensible, as I already wrote it to get my IDE to be helpful. If that is something you do not want contributors to do, that would be a pertinent information to go into such a file.

Some project authors also label issues with labels such as 'good first issue' or 'help wanted', making it easier for contributors to find issues they are (not) supposed to touch.

If this would be more helpful than trying to fix things on my own, I also would not mind to create a Merge Request or two containing only type annotations and true refactorings (behaviour-unchanging ones)?

[Alexofp]

Yeah, separating stuff into different PRs is the best way probably. Issues fixes and refactorings should all be separate x3
And thank you again

[Zsar]

Dunno, if that helps, but I always take care to segregate separate matters into different commits.

In my professional experience, most people do not bother to check commits, but as far as the tools are concerned, this would nominally be a great way to go about it.

So, somehow this is a "life hack" instead of just normal.

[Zsar]

Tested for a while and found no adverse effects. => (hopefully) Ready