forked from RetroPortingToolKit/psxrecomp
-
Notifications
You must be signed in to change notification settings - Fork 0
Review: harden function override boundaries #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Alexbeav
wants to merge
9
commits into
review-base/mstan-6524ded0
Choose a base branch
from
review/func-override-hardening
base: review-base/mstan-6524ded0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
1838b4a
Harden function override boundaries
Alexbeav 9e44684
Add function override lifecycle coverage
Alexbeav 7c5f629
Fix fork review findings
Alexbeav 15f3362
Require dirty tail provenance
Alexbeav 2183cc9
Close late override failure paths
Alexbeav 345f1a1
Restore disc patches after retry
Alexbeav ec7fccb
Preserve disc patch enable state
Alexbeav 7863541
runtime: skip override entry lookups when no hook is armed
Alexbeav ae97ae7
mods: re-arm package overrides on an offline rematch
Alexbeav File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2: The claim that a later successful commit clears the whole failure state is not accurate for disc patches. On a late arming error mod_runtime.cpp sets disc_enabled=false; a subsequent mod_runtime_commit clears main_applied, disc_guard_failed, and the plan but never restores disc_enabled, and mod_runtime_patch_disc_sector returns early while it is false. disc_enabled is only re-enabled by mod_runtime_enable_disc_patches, which is called once at initial boot (main.cpp:13326), so disc overlays remain disabled after a later successful commit/rematch.
Prompt for AI agents