Fix paper filtering bug - #62
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes a silent failure in paper filtering metadata logging and updates the CLI agent runner to match the current backend API (project/user IDs and project creation signature).
Changes:
- Fix
FilterPapersmetadata logging to use theAgentStatedataclass attribute accessor. - Update
agent_cli.pyto passproject_id/user_idintotrigger_stategraph_agent_show_thoughts. - Update CLI project creation call to include the required
log_historyargument.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
llm/nodes/filter_papers.py |
Fixes incorrect state access that could throw and be swallowed by broad exception handling, causing filtering-related metadata to fail. |
llm/agent_cli.py |
Updates CLI entrypoint to align with current agent/backend function signatures and project creation API. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aziz-bouziri
approved these changes
Jan 29, 2026
aziz-bouziri
left a comment
Collaborator
There was a problem hiding this comment.
I just reviewed and tested it locally, and works correctly, well done!
Collaborator
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bad accessor that led to paper filtering failing silently. Also adapts agent_cli.py to past changes in backend.
Fixes #53
Type of change
How Has This Been Tested?
Tested locally in agent_cli and with local web interface. E2E tests passed in this pipeline
Reviewers
@aziz-bouziri