Skip to content

Fix paper filtering bug - #62

Merged
timstruthoff merged 1 commit into
mainfrom
hotfix/paper-filtering
Jan 29, 2026
Merged

timstruthoff merged 1 commit into
mainfrom
hotfix/paper-filtering

Conversation

@timstruthoff

@timstruthoff timstruthoff commented Jan 29, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Fixes a bad accessor that led to paper filtering failing silently. Also adapts agent_cli.py to past changes in backend.

Fixes #53

Type of change

  • Bug fix

How Has This Been Tested?

Tested locally in agent_cli and with local web interface. E2E tests passed in this pipeline

Reviewers

@aziz-bouziri

@timstruthoff
timstruthoff marked this pull request as ready for review January 29, 2026 12:37
Copilot AI review requested due to automatic review settings January 29, 2026 12:37

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a silent failure in paper filtering metadata logging and updates the CLI agent runner to match the current backend API (project/user IDs and project creation signature).

Changes:

  • Fix FilterPapers metadata logging to use the AgentState dataclass attribute accessor.
  • Update agent_cli.py to pass project_id/user_id into trigger_stategraph_agent_show_thoughts.
  • Update CLI project creation call to include the required log_history argument.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
llm/nodes/filter_papers.py Fixes incorrect state access that could throw and be swallowed by broad exception handling, causing filtering-related metadata to fail.
llm/agent_cli.py Updates CLI entrypoint to align with current agent/backend function signatures and project creation API.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread llm/agent_cli.py

@aziz-bouziri aziz-bouziri left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just reviewed and tested it locally, and works correctly, well done!

@timstruthoff

Copy link
Copy Markdown
Collaborator Author

Thanks!

@timstruthoff
timstruthoff merged commit 426e577 into main Jan 29, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

no results agent status not shown properly

3 participants