Skip to content

#68 4.10 Filter out expired screening on movie details page#71

Merged
AlexCode-dot merged 1 commit intomainfrom
4.10-Filter-out-expired-screening-on-movie-details-page
Jun 4, 2025
Merged

#68 4.10 Filter out expired screening on movie details page#71
AlexCode-dot merged 1 commit intomainfrom
4.10-Filter-out-expired-screening-on-movie-details-page

Conversation

@AlexCode-dot
Copy link
Owner

  • Filter out expired screening for detailed moviepage
  • Added user feedback on admin data

Pull Request Type

Please check the type of change your PR introduces:

  • Feature (a new feature for the project)
  • Fix (a bug fix)
  • Chore (updating grunt tasks etc; no production code change)
  • Refactor (refactoring production code)
  • Docs (changes to the documentation)
  • Style (formatting, missing semi colons, etc; no production code change)
  • Test (adding missing tests, refactoring tests; no production code change)

Description

  • This pr includes logic that filter out expired screening for detailed moviepage (better UX for users)
  • Admin user now see feedback when there is no data, for example, if there is no movies listed from the database it will see the message "Inga filmer tillgängliga" and there is now loading state for movies and rooms

Motivation and Context

[Why is this change required? What problem does it solve?]

How Has This Been Tested?

[Describe the tests that you ran to verify your changes]

Screenshots (if appropriate):

[Add screenshots here]

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have named this PR according to following naming convention: #[issue-number] PR description

Additional Information:

[Add any other information about the PR here]

Related Issues:

#68

- Filter out expired screening for detailed moviepage
- Added user feedback on admin data
@vercel
Copy link

vercel bot commented Jun 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kino-next-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2025 10:32am

@AlexCode-dot AlexCode-dot linked an issue Jun 4, 2025 that may be closed by this pull request
3 tasks
Copy link
Collaborator

@Fagerdahl Fagerdahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better UX, great job 👍

@AlexCode-dot AlexCode-dot merged commit 514301b into main Jun 4, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4.10 Filter out expired screening on movie details page

2 participants