Repository navigation
revert: remove out-of-phase analysis and export stubs (#22, #23) - #24
Open
AlessioBrillo wants to merge 1 commit into
Open
AlessioBrillo wants to merge 1 commit into
AlessioBrillo wants to merge 1 commit into
Conversation
This was referenced Oct 7, 2026
The code was not wired to anything and not usable: placeholder web components, encoders returning fixed strings, a job logging with println, a bucket-less "LTTB", a lap segmenter storing absolute time as duration, a Kalman filter TDD-0001 Q3 ruled out, and an unversioned elevation filter (altitude policy is TDD-0001 Q6, still open). V5 also had a foreign key without ON DELETE that would block data deletion. All of it is MVP-2 scope and needs a TDD first. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
AlessioBrillo
force-pushed
the
revert/out-of-phase-analysis-stubs
branch
from
October 8, 2026 13:35
628638a to
726a11e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the code merged by #22/#23: placeholder web components, fake FIT/TCX encoders, a
printlnjob and route, an unversioned Kalman/elevation filter, a lap segmenter and downsampler that do not do what their names say, and migration V5 (activity_laps).Why
Nothing referenced it, none of it had a TDD or ADR, and it is MVP-2 scope (CLAUDE.md: don't scaffold ahead). V5 also had an FK without
ON DELETE, which would block data deletion (next slice). TDD-0001 Q3 ruled out Kalman filtering and Q6 (altitude policy) is still open.Notes
docker compose down -v.Verification
:shared:metrics:jvmTest,:shared:domain:jvmTest,:backend:compileKotlin,ktlintCheck,npm run check.🤖 Generated with Claude Code