Repository navigation
feat(web): the page fades in once on arrival — main and footer, opacity only, 700 ms under a still top bar - #96
Conversation
…ty only, 500 ms on --ease-out under a still top bar, one theme rule for all eleven surfaces
- `main, footer { animation: arrive 500ms var(--ease-out) both }` in the
theme, copied to the five apps and linked by the static pages. Every
surface renders one `main` and one `footer`, so the one rule is the whole
site's arrival; in an app it plays when React mounts `main`, which is the
first moment there is anything to see. A tab or view changing inside a
page does not replay it, because `main` stays mounted.
- Opacity only: the chip stays the one thing that moves on load. Under
reduced motion the same fade is kept, restated by name, as the gentler
variant rather than nothing.
- `web/DESIGN.md`: "Nothing moves on load" becomes "nothing moves on load;
the page fades in once", the arrival joins the allowlist, and the
duration rule names it.
- `tests/test_ui_standard.py`: `main` enters EXPLANATORY for running past
300 ms; `test_the_page_fades_in_once_on_arrival` holds its shape
(one-shot, the ease-out token, a keyframe that moves nothing, kept under
reduced motion); the allowlist's selector boundary is now two-sided, so
`main` does not exempt `.split-main`.
- Checked in Chrome on the homepage, Rules and the built rung 0 app: at
90 ms the content sits at 0.64 opacity under a top bar already at 1.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Claude finished @AlecROndo's task in 40s —— View job Review of PR #96: page fade-in on arrivalI read the diff only. I did not run the test suite or open the site in a browser. The change is small and coherent. The Findings
Docs and pedagogy
Not verified
|
…t, so nothing under main is exempt; the fill is backwards, so the fade lets go when it ends; no sheet may quiet it and every surface renders one main and one footer Review findings on #96, in order: 1. `main` as an EXPLANATORY key reached any selector containing the word, so `main .panel { transition: opacity 600ms }` would have passed the 300 ms, easing and layout gates. A key that is itself a selector list now exempts only the rule whose selector is exactly that list; `_exempts` is the one matcher, shared by `Rule.explanatory` and the ghost test. 2. `both` held `to` after the fade; `to` is the page's own state, and an animation left filling forwards keeps a layer and a stacking context in some engines. `backwards`, and the test refuses a forwards fill. 3. A later `animation: none` on `main` or `footer` would have cut the fade without failing the arrival test: `test_no_sheet_quiets_the_arrival`, over every sheet and media block. 4. The allowlist comment re-wrapped. 5. The premise that one theme rule reaches every page is now held by `test_every_surface_renders_one_main_and_one_footer`: one `<main>` and one `<footer>` per surface, the app's `<main>` unkeyed and the first thing `App` returns. Co-Authored-By: Claude <noreply@anthropic.com>
|
Claude finished @AlecROndo's task in 27s —— View job Review of PR #96 after the second commit (a7298bd)I read the diff only. I did not run The second commit addresses every finding from my first pass. I checked each against the code.
Remaining findings
Docs and pedagogy
Not verified
No finding blocks the merge. 1 and 2 are the ones worth a look. |
|
Review findings dispositioned at a7298bd (
|
…an show; the arrival's comments name the stacking context a forwards fill would leave and why the reduced-motion block restates the fade Second review pass on #96, in order: 1. `test_every_surface_renders_one_main_and_one_footer` no longer looks for `return (` and `<>` five lines above `<main` — a comment there would have failed it and `{cond && <main>}` passed it. It now strips comments, counts one `<main` and one `<footer` per shell, refuses a `key=` on `<main` and a conditional on its opening line, and its docstring says what escapes it. 2. The reduced-motion restatement stays: the standard quiets by name (`test_every_pulse_and_travel_is_quieted_under_reduced_motion` fails for an animating selector with no reduced-motion rule of its own), and the arrival's quiet form is the same fade. The comment now says so instead of "so the test can see it". 3. `web/DESIGN.md` step 4 re-wrapped. 4. The theme comment and the test docstring name the consequence of a forwards fill — `main` kept as a stacking context, under which nothing inside it could rise above the top bar — in place of "in some engines". Co-Authored-By: Claude <noreply@anthropic.com>
|
Claude finished @AlecROndo's task in 34s —— View job Review of PR #96 after the third commit (48d7923)I read the diff of 48d7923 only. I did not run The commit answers the two remaining findings from my last pass that were worth acting on. The one-main-one-footer test is looser and says what it can't prove. The reduced-motion restatement stays, now with a stated reason. Comments and docs agree with the code. The five
Remaining findings
Docs and pedagogy
Not verified
No finding blocks the merge. Finding 1 is the only one worth a look. |
|
Second-pass findings dispositioned at 48d7923:
|
…re `<main`, not any `?` on its line Third review pass on #96: `&&|\?[^.]|\bif\b` over the whole opening line would have failed a `<main` whose attribute carried a `?`, and `?[^.]` was a loose proxy for a ternary. The check is now `(&&|\?|:)\s*\(?\s*<main`, which is how JSX renders a tag conditionally and nothing else: `{open && <main`, `{x ? (<main`, `: <main` fail; `<main className={a ? "x" : "y"}>` and a `?` in a URL do not. Probed on both sides before committing. Co-Authored-By: Claude <noreply@anthropic.com>
|
Third-pass findings dispositioned at the branch head (
|
|
Claude finished @AlecROndo's task in 18s —— View job Review of PR #96 after the fourth commit (838853a)I read the diff of 838853a only. I did not run The commit changes one assertion in Findings
Docs and pedagogy
Not verified
No finding blocks the merge. Finding 2 is the one worth a look. |
…ss lines, and the pattern's probes are a test Fourth review pass on #96: the operator check ran on the one line that opened `<main`, so Prettier's `{open && (` newline `<main` escaped it. `CONDITIONAL_MAIN` now runs over the whole comment-stripped shell, and the cases probed by hand in the last commit — four conditional renders, the five real openings and a `?` in an attribute — are a parametrized test, so a later edit to the pattern cannot loosen it unnoticed. The `:` stays: a ternary's else branch is a real conditional render, and a `case x:` before `<main` would fail loudly by line. Co-Authored-By: Claude <noreply@anthropic.com>
|
Fourth-pass findings dispositioned at the branch head (
|
|
Claude finished @AlecROndo's task in 12s —— View job Review of PR #96 after the fifth commit (a4476b6)I read the diff of a4476b6 only. I did not run The commit answers both findings from my last pass. The conditional check now runs over the whole comment-stripped text, so a conditional on the previous line ( Findings
Docs and pedagogy
Not verified
No finding blocks the merge. Every earlier finding is addressed or answered with a stated reason. |
|
Fifth-pass findings dispositioned at a4476b6, with no further commit — each is a nit on the tripwire test with no wrong claim, no failing test and no behaviour change in
Across all five passes: 1–5 of the first review fixed (a7298bd); 1, 3, 4 of the second fixed and 2 kept with a reason (48d7923); 1 of the third fixed (838853a); 2 and 3 of the fourth fixed (a4476b6); every remaining item is a nit or informational with a stated reason. The phone, throttled-connection and 4x Animations checks remain the PR's own open boxes for its author.
|
…ick on localhost; the test, the standard and the allowlist reason say 700
|
Claude finished @AlecROndo's task in 19s —— View job Review of PR #96 after the sixth commit (8f17cd7)I read the diff of 8f17cd7 only. I did not run The commit changes the arrival from 500 ms to 700 ms. It touches the Findings
Docs and pedagogy
Not verified
No finding blocks the merge. Finding 1 is the only one that needs an action. |
|
Sixth-pass finding 1 — fixed: the PR title and body now say 700 ms, and the Chrome numbers are marked as measured at the earlier 500. Findings 2 and 3 are informational; no change. The phone and throttled-connection check stays the PR's open box. |
Summary
main, footer { animation: arrive 700ms var(--ease-out) both }. Every page renders onemainand onefooter, so the static pages get it through/theme.cssand the apps when React mountsmain. A tab or view changing inside a page does not replay it.Changes
web/rung0-viz/src/theme.css(and the four byte-identical copies): thearrivekeyframe and rule, restated in the reduced-motion block; the header's third point now says the content fades in once.web/DESIGN.md: "Nothing moves on load" becomes "nothing moves on load; the page fades in once"; the arrival joins the allowlist and the duration rule.tests/test_ui_standard.py:mainentersEXPLANATORYfor running past 300 ms;test_the_page_fades_in_once_on_arrivalholds its shape (one-shot, the ease-out token, a keyframe that moves nothing, kept under reduced motion); the allowlist's selector boundary is two-sided, somaindoes not exempt.split-main.Test plan
uv run pytest— the full default suite passesnpm testinweb/rung0-viz(the four other apps carry the same theme bytes;test_shared_chromeholds them equal)main.getAnimations()is the onearrive, 700 ms, one iteration; at 90 ms the content was at 0.64 opacity under a top bar at 1 (measured at 500 ms, before Alec asked for 700 on localhost)