Launcher: Show the update icon next to mod items in list#1447
Launcher: Show the update icon next to mod items in list#1447julianxhokaxhiu wants to merge 1 commit into
Conversation
|
There will be two icons indicating an update ? |
|
One will indicate there's some attention needed, and one that there's an update for it, Reason why I didn't replace it is because I don't know if the attention is used for something else as well. I'm fine unifying them as one, but I'd need some guidance from you, @DV666, @Tirlititi and @WarpedEdge as you better know this launcher than me. |
|
I'm not against the idea if we want to keep only the exclamation mark symbol for updates. I would like to get the others feedback though before going that direction. Thanks a lot |
Sorry, I've been really busy lately, so I'm having a hard time keeping up with what's going on. For me,
That’s just a quick thought I had right now, my dear Odin ^^ and thanks again for everything you do! |
|
Thanks @DV666 really appreciated your kind words. While you're right that the new icon will come around in the same place, we are still trying to figure out if the update icon shall be just one ( the exclamation mark ) or keep both ( as I don't know if the excalamation mark is used for anything else ). If we agree to use only the exclamation mark I'm fine with it and I shift also the click function to start the update on top of it ( instead of binding it to the emoji icon ). If you agree on that, I happy to update the PR code. |
|
I think the exclamation is good on the mods tab to say there is something
to look at, but when on the mods catalog the new mods will have the “new”
tag. If the new mods were the only thing and not new mod updates, after
they visited the page once, the exclamation on the mods tab disappears, but
the new tag on the mods stays there for the set amount of days. Hope that
makes sense.
…On Mon, Jun 22, 2026 at 5:31 PM Julian Xhokaxhiu ***@***.***> wrote:
*julianxhokaxhiu* left a comment (Albeoris/Memoria#1447)
<#1447 (comment)>
Thanks @DV666 <https://github.com/DV666> really appreciated your kind
words. While you're right that the new icon will come around in the same
place, we are still trying to figure out if the update icon shall be just
one ( the exclamation mark ) or keep both ( as I don't know if the
excalamation mark is used for anything else ).
If we agree to use only the exclamation mark I'm fine with it and I shift
also the click function to start the update on top of it ( instead of
binding it to the emoji icon ). If you agree on that, I happy to update the
PR code.
—
Reply to this email directly, view it on GitHub
<#1447?email_source=notifications&email_token=AVQGRMQYTBHMAG2MNYZ5SWD5BGQSNA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZXGMZDMMBQGU42M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-4773260059>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVQGRMTRNGEH7NG3HUXLI6T5BGQSNAVCNFSNUABEKJSXA33TNF2G64TZHM2TOMBQGIZDQNB3JFZXG5LFHM2DMOJUHA2DQNJQHCQXMAQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Again, please let's not mix waters. This PR is only for the update functionality, we will discuss the new icon on a separate PR. The feedback I need is, do we want the double icons as in my screenshots, or a single one as in @faospark screenshots. That's the question :) |
|
Oh sorry, then yeah I agree with Fao as well
…On Thu, Jun 18, 2026 at 5:16 PM Julian Xhokaxhiu ***@***.***> wrote:
*julianxhokaxhiu* left a comment (Albeoris/Memoria#1447)
<#1447 (comment)>
One will indicate there's some attention needed, and one that there's an
update for it, Reason why I didn't replace it is because I don't know if
the attention is used for something else as well. I'm fine unifying them as
one, but I'd need some guidance from you, @DV666
<https://github.com/DV666>, @Tirlititi <https://github.com/Tirlititi> and
@WarpedEdge <https://github.com/WarpedEdge> as you better know this
launcher than me.
—
Reply to this email directly, view it on GitHub
<#1447?email_source=notifications&email_token=AVQGRMTAI6JUMZLPIDE2C4L5ARL2NA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZUGYYTSNZTGY42M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-4746197369>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVQGRMVV2242FY66XUPXXR35ARL2NAVCNFSNUABEKJSXA33TNF2G64TZHM2TOMBQGIZDQNB3JFZXG5LFHM2DMOJUHA2DQNJQHCQXMAQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|



This PR will add add the following icon
to the My mods tab or Mod Catalog tab, wherver the mod that requires an update needs attention.
The change was requested on Discord and I'm mainly enabling such request to happen in the Launcher. Regarding the technical implementation I'm not super happy about it, so if you have any idea on how we could improve it please be my guest, but this is the best I was able to come up with.
After this PR the launcher will look like this when a mod requires an update:


I tested this only on Windows but should be working fine under Linux as well as the rendering technique is the same used in the Mods tab. The only difference is the visibility binding.
Any question as always, feel free to ask.