Skip to content

feat: add ASCircularWeb Medium and Bold @font-face registrations AB#1605294 - #290

Open
sun-mota wants to merge 1 commit into
masterfrom
sunMota/500-700-ac
Open

feat: add ASCircularWeb Medium and Bold @font-face registrations AB#1605294#290
sun-mota wants to merge 1 commit into
masterfrom
sunMota/500-700-ac

Conversation

@sun-mota

@sun-mota sun-mota commented Jul 30, 2026

Copy link
Copy Markdown
Member

Registers ASCircularWeb-Medium (500) in the Alaska theme font stack. Adds ASCircularWeb-Bold (700) to the legacy auro-classic font stack.

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: # (issue, if applicable)

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

Summary by Sourcery

Register new ASCircularWeb medium and bold font faces in the Alaska and legacy auro-classic font stacks.

New Features:

  • Add ASCircularWeb-Medium font registration to the Alaska theme brand primary font stack.
  • Add ASCircularWeb-Bold font registration to the legacy auro-classic circular font family.

@sun-mota
sun-mota requested a review from a team as a code owner July 30, 2026 17:47
@sun-mota sun-mota self-assigned this Jul 30, 2026
@sourcery-ai

sourcery-ai Bot commented Jul 30, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR registers ASCircularWeb-Medium in the Alaska theme font stack and adds ASCircularWeb-Bold to the legacy auro-classic font stack via @font-face and mixin updates.

Flow diagram for updated font registrations in Alaska and auro_classic stacks

flowchart LR
  AlaskaTheme[Alaska theme]
  AuroClassic[auro_classic legacy stack]
  FontMixin[font-face mixin]
  ASCircularWebLight[ASCircularWeb-Light]
  ASCircularWebBook[ASCircularWeb-Book]
  ASCircularWebMedium[ASCircularWeb-Medium]
  ASCircularWebBold[ASCircularWeb-Bold]

  AlaskaTheme --> FontMixin
  FontMixin --> ASCircularWebLight
  FontMixin --> ASCircularWebBook
  FontMixin --> ASCircularWebMedium

  AuroClassic --> ASCircularWebBook
  AuroClassic --> ASCircularWebBold
Loading

File-Level Changes

Change Details Files
Add bold ASCircularWeb font-face to the legacy auro-classic stack.
  • Define a new @font-face block using the shared circular family variable with font-weight set to bold and normal style.
  • Configure font-display as fallback to align with existing font loading behavior.
  • Reference production-hosted ASCircularWeb-Bold assets in both woff2 and woff formats for broad browser support.
src/fonts/legacy/_auro-classic.scss
Register ASCircularWeb-Medium in the Alaska theme font stack.
  • Invoke the font-face mixin for the primary brand family with the medium weight token.
  • Map the mixin to the ASCircularWeb-Medium asset name using the existing unicode-range for English.
  • Place the new registration alongside existing Light and Book weights to maintain ordering and consistency.
src/fonts/themes/_alaska.scss

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions

github-actions Bot commented Jul 30, 2026

Copy link
Copy Markdown

🚀 PR Release Published! v0.0.0-pr290.6

To install:

npm install @aurodesignsystem-dev/webcorestylesheets@0.0.0-pr290.6

Install via alias:

npm install @aurodesignsystem@npm:@aurodesignsystem-dev/webcorestylesheets@0.0.0-pr290.6

View on npmjs.com

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue, and left some high level feedback:

  • In the new ASCircularWeb-Bold @font-face, the second src URL has an extra space in the scheme ("https: //..."), which will break loading and should be corrected to a valid URL.
  • The ASCircularWeb-Bold src entries use format("woff2") and format("woff") but both URLs end in .woff, so please double-check the correct file extensions and formats to ensure the browser selects the right source.
  • For consistency with the rest of the font stack, consider using a numeric value (700) for font-weight instead of bold and aligning the comment to that convention.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- In the new ASCircularWeb-Bold @font-face, the second src URL has an extra space in the scheme (`"https: //..."`), which will break loading and should be corrected to a valid URL.
- The ASCircularWeb-Bold src entries use `format("woff2")` and `format("woff")` but both URLs end in `.woff`, so please double-check the correct file extensions and formats to ensure the browser selects the right source.
- For consistency with the rest of the font stack, consider using a numeric value (`700`) for `font-weight` instead of `bold` and aligning the comment to that convention.

## Individual Comments

### Comment 1
<location path="src/fonts/legacy/_auro-classic.scss" line_range="48-49" />
<code_context>
+  font-style: normal;
+
+  font-display: fallback;
+  src: url("https://www.alaskaair.com/v3/assets/blt2cefe12c88e9dd91/blt0e0c0ce2b87c10f2/ASCircularWeb-Bold.woff?environment=production") format("woff2"),
+    url("https: //www.alaskaair.com/v3/assets/blt2cefe12c88e9dd91/blt0e0c0ce2b87c10f2/ASCircularWeb-Bold.woff?environment=production") format("woff");
+}
</code_context>
<issue_to_address>
**issue (bug_risk):** Second font src URL has an extra space after the protocol and may be invalid.

That space in `"https: //www..."` makes the second `src` URL invalid, so the font source will not load. In addition, both `src` entries reference the same `.woff` file but declare different formats (`woff2` vs `woff`); if separate files exist for each format, you should link to the correct asset for each to avoid loading issues or inconsistent behavior.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment thread src/fonts/legacy/_auro-classic.scss Outdated
@sun-mota
sun-mota force-pushed the sunMota/500-700-ac branch 5 times, most recently from ede492e to f97ca4c Compare July 30, 2026 18:28
Comment thread src/fonts/themes/_alaska-classic.scss
Comment thread src/fonts/themes/_alaska-classic.scss
@sun-mota
sun-mota requested a review from chrisfalaska July 31, 2026 16:18
@sun-mota
sun-mota force-pushed the sunMota/500-700-ac branch from f97ca4c to aa51258 Compare July 31, 2026 16:19
@sun-mota
sun-mota force-pushed the sunMota/500-700-ac branch 2 times, most recently from 0ae8737 to f5b5ad7 Compare August 10, 2026 20:45
…605294

Registers ASCircularWeb-Medium (500) in the Alaska theme font stack.
Adds ASCircularWeb-Bold (700) to the legacy auro-classic font stack.
@sun-mota
sun-mota force-pushed the sunMota/500-700-ac branch from f5b5ad7 to a3b9ac6 Compare August 10, 2026 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants