feat: add ASCircularWeb Medium and Bold @font-face registrations AB#1605294 - #290
Open
sun-mota wants to merge 1 commit into
Open
feat: add ASCircularWeb Medium and Bold @font-face registrations AB#1605294#290sun-mota wants to merge 1 commit into
sun-mota wants to merge 1 commit into
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR registers ASCircularWeb-Medium in the Alaska theme font stack and adds ASCircularWeb-Bold to the legacy auro-classic font stack via @font-face and mixin updates. Flow diagram for updated font registrations in Alaska and auro_classic stacksflowchart LR
AlaskaTheme[Alaska theme]
AuroClassic[auro_classic legacy stack]
FontMixin[font-face mixin]
ASCircularWebLight[ASCircularWeb-Light]
ASCircularWebBook[ASCircularWeb-Book]
ASCircularWebMedium[ASCircularWeb-Medium]
ASCircularWebBold[ASCircularWeb-Bold]
AlaskaTheme --> FontMixin
FontMixin --> ASCircularWebLight
FontMixin --> ASCircularWebBook
FontMixin --> ASCircularWebMedium
AuroClassic --> ASCircularWebBook
AuroClassic --> ASCircularWebBold
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
🚀 PR Release Published! To install: npm install @aurodesignsystem-dev/webcorestylesheets@0.0.0-pr290.6Install via alias: npm install @aurodesignsystem@npm:@aurodesignsystem-dev/webcorestylesheets@0.0.0-pr290.6 |
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- In the new ASCircularWeb-Bold @font-face, the second src URL has an extra space in the scheme (
"https: //..."), which will break loading and should be corrected to a valid URL. - The ASCircularWeb-Bold src entries use
format("woff2")andformat("woff")but both URLs end in.woff, so please double-check the correct file extensions and formats to ensure the browser selects the right source. - For consistency with the rest of the font stack, consider using a numeric value (
700) forfont-weightinstead ofboldand aligning the comment to that convention.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In the new ASCircularWeb-Bold @font-face, the second src URL has an extra space in the scheme (`"https: //..."`), which will break loading and should be corrected to a valid URL.
- The ASCircularWeb-Bold src entries use `format("woff2")` and `format("woff")` but both URLs end in `.woff`, so please double-check the correct file extensions and formats to ensure the browser selects the right source.
- For consistency with the rest of the font stack, consider using a numeric value (`700`) for `font-weight` instead of `bold` and aligning the comment to that convention.
## Individual Comments
### Comment 1
<location path="src/fonts/legacy/_auro-classic.scss" line_range="48-49" />
<code_context>
+ font-style: normal;
+
+ font-display: fallback;
+ src: url("https://www.alaskaair.com/v3/assets/blt2cefe12c88e9dd91/blt0e0c0ce2b87c10f2/ASCircularWeb-Bold.woff?environment=production") format("woff2"),
+ url("https: //www.alaskaair.com/v3/assets/blt2cefe12c88e9dd91/blt0e0c0ce2b87c10f2/ASCircularWeb-Bold.woff?environment=production") format("woff");
+}
</code_context>
<issue_to_address>
**issue (bug_risk):** Second font src URL has an extra space after the protocol and may be invalid.
That space in `"https: //www..."` makes the second `src` URL invalid, so the font source will not load. In addition, both `src` entries reference the same `.woff` file but declare different formats (`woff2` vs `woff`); if separate files exist for each format, you should link to the correct asset for each to avoid loading issues or inconsistent behavior.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
sun-mota
force-pushed
the
sunMota/500-700-ac
branch
5 times, most recently
from
July 30, 2026 18:28
ede492e to
f97ca4c
Compare
chrisfalaska
requested changes
Jul 30, 2026
sun-mota
force-pushed
the
sunMota/500-700-ac
branch
from
July 31, 2026 16:19
f97ca4c to
aa51258
Compare
sun-mota
force-pushed
the
sunMota/500-700-ac
branch
2 times, most recently
from
August 10, 2026 20:45
0ae8737 to
f5b5ad7
Compare
…605294 Registers ASCircularWeb-Medium (500) in the Alaska theme font stack. Adds ASCircularWeb-Bold (700) to the legacy auro-classic font stack.
sun-mota
force-pushed
the
sunMota/500-700-ac
branch
from
August 10, 2026 21:00
f5b5ad7 to
a3b9ac6
Compare
chrisfalaska
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registers ASCircularWeb-Medium (500) in the Alaska theme font stack. Adds ASCircularWeb-Bold (700) to the legacy auro-classic font stack.
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: # (issue, if applicable)
Summary:
Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team
Summary by Sourcery
Register new ASCircularWeb medium and bold font faces in the Alaska and legacy auro-classic font stacks.
New Features: