Skip to content

Restrict native library discovery to package and explicit paths - #8

Merged
tobyrjackson merged 1 commit into
mainfrom
fix/native-library-discovery
Nov 17, 2026
Merged

tobyrjackson merged 1 commit into
mainfrom
fix/native-library-discovery

Conversation

@tobyrjackson

@tobyrjackson tobyrjackson commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

On Windows, automatic native-library discovery can search developer directories such as C:\projects\Akiki\akiki-inference. The same loader also checks home-directory checkouts, workspace caches, and Cargo outputs on other systems.

Limit automatic discovery to the installed package's native directory for VAD and decision-model inference. Keep the existing override order: library_path, then AKIKI_VAD_LIBRARY or AKIKI_MINILM_LIBRARY, then the bundled library. A missing or incompatible explicit library does not select another library. VAD automatic engine selection still supports ONNX, then PyTorch compatibility fallbacks.

Document the runtime paths needed for source-checkout tests. Add 36 regression cases for Windows, macOS, and Linux. These cases cover both engines, developer outputs, explicit path precedence, and failed overrides.

Validation: 456 tests passed offline with both existing local native libraries required. Eleven checks were skipped because ONNX Runtime or an explicit real-model path was unavailable. Ruff and formatting checks passed. Desktop wheels passed clean-install and native inference tests on Windows x64, macOS Intel, and macOS Apple Silicon. Each installed-wheel suite passed 441 tests, with 19 optional checks skipped. See workflow run 44164743025.

Fixes #4.

@tobyrjackson
tobyrjackson marked this pull request as ready for review November 17, 2026 20:10
@tobyrjackson
tobyrjackson merged commit 8f8402b into main Nov 17, 2026
11 checks passed
@tobyrjackson
tobyrjackson deleted the fix/native-library-discovery branch November 17, 2026 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

on windows searches for dlls in various directories. need to limit search

1 participant