Repository navigation
Restrict native library discovery to package and explicit paths - #8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, automatic native-library discovery can search developer directories such as
C:\projects\Akiki\akiki-inference. The same loader also checks home-directory checkouts, workspace caches, and Cargo outputs on other systems.Limit automatic discovery to the installed package's
nativedirectory for VAD and decision-model inference. Keep the existing override order:library_path, thenAKIKI_VAD_LIBRARYorAKIKI_MINILM_LIBRARY, then the bundled library. A missing or incompatible explicit library does not select another library. VAD automatic engine selection still supports ONNX, then PyTorch compatibility fallbacks.Document the runtime paths needed for source-checkout tests. Add 36 regression cases for Windows, macOS, and Linux. These cases cover both engines, developer outputs, explicit path precedence, and failed overrides.
Validation: 456 tests passed offline with both existing local native libraries required. Eleven checks were skipped because ONNX Runtime or an explicit real-model path was unavailable. Ruff and formatting checks passed. Desktop wheels passed clean-install and native inference tests on Windows x64, macOS Intel, and macOS Apple Silicon. Each installed-wheel suite passed 441 tests, with 19 optional checks skipped. See workflow run 44164743025.
Fixes #4.