Skip to content

Add Airship 2 Under the Hood Blog#165

Open
drewwalters96 wants to merge 2 commits into
AirshipWeb:masterfrom
drewwalters96:airship2-under-the-hood
Open

Add Airship 2 Under the Hood Blog#165
drewwalters96 wants to merge 2 commits into
AirshipWeb:masterfrom
drewwalters96:airship2-under-the-hood

Conversation

@drewwalters96

Copy link
Copy Markdown
Collaborator

No description provided.

@drewwalters96 drewwalters96 force-pushed the airship2-under-the-hood branch 4 times, most recently from 23364e3 to b63a961 Compare May 5, 2021 16:03

@jimmytipit jimmytipit left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi - biggest problem at first glance are the img markdown tags:

(/images/4.png)

Should be, according to your commit:

(/img/under_the_hood_blog/4.png)

Let's start with that and see if it builds. Also, have you tried to build locally? You generally get more helpful error messages. Details here: https://github.com/AirshipWeb/airship-website/blob/master/README.md

Cheers,
Jimmy

@drewwalters96 drewwalters96 force-pushed the airship2-under-the-hood branch from b63a961 to 5d484a5 Compare May 12, 2021 18:44
@drewwalters96

Copy link
Copy Markdown
Collaborator Author

Hey, thanks for the pointers, Jimmy. I will go ahead and set up a local environment if that will produce some more output.

Best,
Drew

@drewwalters96

Copy link
Copy Markdown
Collaborator Author

@jimmytipit running yarn build locally, I am still getting the same output as in the CI jobs. Is there a more verbose command you recommend?

I also tried removing the images, but the build still fails. When I shortened the post, it did build successfully. I'm not sure if I removed a line that was rendering incorrectly or if there is a size limit on the blogs posts. Appreciate any suggestions you have.

Thanks,
Drew

@jimmytipit

Copy link
Copy Markdown
Collaborator

I'm going to clone your repo and see if I can figure it out :)

- Lines 366-370 and 372-374 werent' working properly for referenced links.
-  Swapped out for HTML for the anchor tags
- Honestly, I tried 1m ways to try to fix it, and was totally stumped
- Also made a number of minor markdown corrections

Signed-off-by: Jimmy McArthur <jimmy@tipit.net>
@jimmytipit

Copy link
Copy Markdown
Collaborator

This was really weird. There was some combination of things in the markdown that were preventing the normal working reference links (e.g. [blah][1]) from working properly. I swapped out with a bit of Html and slightly different markdown. Should be good to go now.

@jimmytipit jimmytipit marked this pull request as ready for review May 18, 2021 21:23
@jimmytipit

Copy link
Copy Markdown
Collaborator

Not sure when you're wanting this to go live @drewwalters96 - but it's ready to merge at any time now.

@drewwalters96

Copy link
Copy Markdown
Collaborator Author

Thanks! I really appreciate the help, Jimmy. I just sent this to Rodolfo to make sure he's ready to publish.

@jimmytipit

jimmytipit commented May 18, 2021 via email

Copy link
Copy Markdown
Collaborator

@drewwalters96 drewwalters96 changed the title WIP: Add Airship 2 Under the Hood Blog Add Airship 2 Under the Hood Blog May 20, 2021

The image below expresses the lifecycle in terms of Stages and Phases.

![](/img/under_the_hood_blog/4.png)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can barely guess what is written on this picture. Is it possible to make a bigger text/picture?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants