Automated PR feature/calculate-aqi-service into Main#16
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds an AQI calculation service and persistence so the API can compute AQI on reading ingest and expose a “latest AQI for station” endpoint.
Changes:
- Renames PM2.5 field from
Pm2_5toPm25across view model/model usage. - Introduces
IAqiCalculator+EpaAqiCalculatorand wires it into DI to compute/storeAqiRecordonPOST /api/v1/readings. - Adds
AqiRecordsEF DbSet + a newGET /api/v1/stations/{id}/aqi/latestendpoint.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 14 comments.
Show a summary per file
| File | Description |
|---|---|
| AirAware/ViewModels/CreateReadingViewModel.cs | Renames inbound PM2.5 field to Pm25. |
| AirAware/Models/Reading.cs | Renames persisted PM2.5 property to Pm25. |
| AirAware/Services/IAqiCalculator.cs | Adds AQI calculator interface + AqiResult. |
| AirAware/Services/AqiCalculator.cs | Implements EPA breakpoint-based AQI calculation. |
| AirAware/Models/AqiRecord.cs | Adds persisted AQI record model. |
| AirAware/Data/AppDbContext.cs | Adds DbSet<AqiRecord> to EF context. |
| AirAware/Startup.cs | Registers AQI calculator in DI. |
| AirAware/Controllers/ReadingController.cs | Computes AQI and writes an AqiRecord on reading ingest. |
| AirAware/Controllers/StationController.cs | Adds endpoint to fetch the latest AQI for a station. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
92
to
+97
| await context.Readings.AddAsync(reading); | ||
| await context.SaveChangesAsync(); | ||
| return Created($"api/v1/readings/{reading.Id}", reading); | ||
|
|
||
| // compute AQI synchronously | ||
| var (final, pm25Result, pm10Result) = aqiCalculator.Calculate(reading); | ||
|
|
There was a problem hiding this comment.
Readings are saved, then AqiRecords are saved in a separate SaveChangesAsync() without a transaction. If the AQI insert fails, you’ll persist a reading without its AQI record. Consider adding the AqiRecord to the context and saving both in a single SaveChangesAsync() (or use an explicit transaction).
joaoferreira-dev
approved these changes
Feb 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.