feat(subtitles): support VobSub (.sub+.idx) external bitmap subtitles - #952
Closed
TsangAsuna wants to merge 2 commits into
Closed
TsangAsuna wants to merge 2 commits into
TsangAsuna wants to merge 2 commits into
Conversation
On tablet-like devices during fullscreen playback (hidden control bar) the media capture dialog disabled barrier dismissal, leaving the top-right close button as the only way to close it. Pass barrierDismissible: true unconditionally so tapping outside the dialog closes it, consistent with other Nipaplay windows.
- Add .idx to subtitle extension whitelists (constants, utils, pickers) - Sniff MPEG-PS pack header in .sub so binary VobSub skips text decoding - Fix IDX fallback being overwritten by the decode-failure reload path - Enforce .sub+.idx pairing at candidate/scan/auto-load layers - Cache paired .sub beside remote .idx for player bitmap lookup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.idxto subtitle extension whitelists (constants, utils, file pickers on desktop/Apple and Android).subso binary VobSub skips text decoding/encoding repair; MicroDVD text unaffectedreturnafter IDX attach).sub+.idxpairing at every candidate layer: remote lists (dandanplay/WebDAV/SMB x2/shared/managed), local scans, auto-load scoring; orphan.idxis excluded.idxcaching now downloads the paired.subbeside it as<hash>.sub(player locates bitmap data by same-name.sub)Quality gate
flutter analyze --no-fatal-infos --no-fatal-warnings lib: 2010 issues before and after (baseline unchanged, 0 new)flutter test: same 6 pre-existing failures as baseline (unrelated to subtitles)Test plan